Skip to content

fix: talk modal z-index #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GVodyanov wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix: talk modal z-index #8607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions css/app-modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
h2 {
margin: 0;
}

}

fieldset {
padding: calc(var(--default-grid-baseline) * 4) 0;

header {

h3 {
h3 {
font-size: 20px;
font-weight: 600;
margin: var(--default-grid-baseline) 0;
Expand Down Expand Up @@ -72,6 +72,10 @@
}
}

.modal-mask.add-talk-modal {
z-index: 10000 !important;

@ChristophWurst ChristophWurst Jul 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 10k and how did this regress?

@ChristophWurst ChristophWurst Jul 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this regressed or #8064 never worked. I'm challenging this because the force z-indexes are a code smell.
Let's find a scaling solution without monkey patches.

Edit simple is probably too high on the z-index. It should be below the standard NcModal as I can't think of a setup where it would be above.

@SebastianKrupinski SebastianKrupinski Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to say it was working in #8064 and broke when the anchor point was changed in #8533

}

.app-config-modal-confirmation {
.empty-content {
margin-top: 0 !important;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Editor/AddTalkModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<template>
<NcModal
size="small"
class="modal"
class="modal add-talk-modal"
:name="t('calendar', 'Select a Talk Room')"
@close="$emit('close', $event)">
<div class="modal-content">
Expand Down
Loading