fix: talk modal z-index#8607
Open
GVodyanov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Grigory V <scratchx@gmx.com>
GVodyanov
force-pushed
the
fix/talk-modal-z-index
branch
from
July 16, 2026 12:24
9ed80d2 to
0b8c4c2
Compare
| } | ||
|
|
||
| .modal-mask.add-talk-modal { | ||
| z-index: 10000 !important; |
Member
There was a problem hiding this comment.
why 10k and how did this regress?
Member
There was a problem hiding this comment.
Either this regressed or #8064 never worked. I'm challenging this because the force z-indexes are a code smell.
Let's find a scaling solution without monkey patches.
Edit simple is probably too high on the z-index. It should be below the standard NcModal as I can't think of a setup where it would be above.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix edit simple modal overlapping the talk modal
🤖 AI (if applicable)