Make google-site-verification meta tag configurable (#90)#513
Draft
kltm wants to merge 1 commit into
Draft
Conversation
The google-site-verification meta tag was hard-coded identically across four layouts. Add a per-environment `google_site_verification` setting (settings.yml) and an `ApplicationHelper#google_site_verification_meta_tag` helper that renders it, omitting the tag on the appliance and when no token is configured. Replace the hard-coded tag in the _header, angular, partial, and popup layouts with the helper. Includes a helper unit test (configured / blank / appliance) and a full-stack integration test asserting the tag's presence/absence in a rendered page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
google-site-verificationmeta tag was hard-coded (the same token) across four layouts. This makes it configurable:google_site_verificationkey inconfig/settings.yml(token for staging/production;nullfor development/test/appliance), mirroring howgoogle_analyticsis handled.ApplicationHelper#google_site_verification_meta_tagthat renders the tag, omitting it on the appliance and when no token is configured._header,angular,partial, andpopuplayouts now call the helper instead of hard-coding the tag (incidentally givingpartial/popupthe same appliance suppression the other two already had).Testing
Both green in the dev container.
Dependency
CI here depends on the
minitest5.x pin in #512 (the Rails 8 Minitest harness is otherwise broken andbin/rails testcrashes). Once #512 lands, this PR's tests run clean; I'll rebase onmasterafterward.Closes #90.
— Posted by Claude Code agent on behalf of @kltm.