Fix stale 500 error page wording (#144); pin minitest for the Rails 8 test runner#512
Open
kltm wants to merge 2 commits into
Open
Fix stale 500 error page wording (#144); pin minitest for the Rails 8 test runner#512kltm wants to merge 2 commits into
kltm wants to merge 2 commits into
Conversation
minitest 6.0.3 changed run_suite's calling convention, which is incompatible with the Rails 8.0.x test runner (railties test_unit/line_filtering): `bin/rails test` raises "wrong number of arguments" in line_filtering.rb and crashes before any test runs. Pin minitest to ~> 5.25 and document the constraint in CLAUDE.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The internal server error page claimed "We have been notified of this error", which dates from when Airbrake was in place; it is no longer accurate (and misleading on the appliance). Replace it with a neutral apology and add a view-render test asserting the stale copy is gone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
@jvendetti This is necessary for the other small draft change at #513 . I'm not sure if a version bump would interfere with anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes, kept as separate commits:
minitestto~> 5.25(test-infra prerequisite).minitest 6.0.3(resolved transitively underminitest (>= 5.1)) changedrun_suite's calling convention and is incompatible with the Rails 8.0.x test runner (railtiestest_unit/line_filtering):bin/rails testcrashes withwrong number of arguments (given 3, expected 1..2)before any test runs. This pin restores the entire Minitest suite. Documented inCLAUDE.md.Testing
In the dev container:
sudo RAILS_ENV=test bin/rails test test/views/errors_view_test.rb→ green. (The minitest pin is what allows the harness to run at all.)Notes
The minitest pin is bundled here because it is a prerequisite for running these — and all other — Minitest tests on Rails 8. It is isolated as its own commit so it can be reviewed or cherry-picked independently.
Closes #144.
— Posted by Claude Code agent on behalf of @kltm.