Skip to content

fix: draw no text shadow for text-shadow: none #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YevheniiKotyrlo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: draw no text shadow for text-shadow: none #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
656a973
fix(native): read a runtime shadow the way the compiler does
YevheniiKotyrlo Oct 16, 2026
7ff49fa
fix(native): an invalid box shadow sets nothing, as an invalid text o…
YevheniiKotyrlo Oct 16, 2026
808d456
fix: draw no text shadow for text-shadow: none
YevheniiKotyrlo Oct 16, 2026
18f40b2
fix(compiler): keep the runtime delay, and compile text-shadow: none
YevheniiKotyrlo Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/__tests__/native/box-shadow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ describe("shadow values from runtime variables", () => {
offsetX: 0,
offsetY: 4,
blurRadius: 6,
spreadDistance: 0,
color: "#000",
},
]);
Expand All @@ -515,13 +516,13 @@ describe("shadow values from runtime variables", () => {
render(<View testID={testID} className="test" />);
const component = screen.getByTestId(testID);

// Runtime path has no default color injection (compile-time adds currentcolor)
expect(component.props.style.boxShadow).toStrictEqual([
{
offsetX: 0,
offsetY: 4,
blurRadius: 6,
spreadDistance: -1,
color: { semantic: ["label", "labelColor"] },
},
]);
});
Expand Down Expand Up @@ -595,7 +596,7 @@ describe("shadow values from runtime variables", () => {
]);
});

test("inset shadow - without color has broken color parsing (known limitation)", () => {
test("inset shadow - without color", () => {
registerCSS(
`.test {
--my-shadow: inset 0 0 10px 5px;
Expand All @@ -607,18 +608,14 @@ describe("shadow values from runtime variables", () => {
render(<View testID={testID} className="test" />);
const component = screen.getByTestId(testID);

// TODO: Known bug — runtime shorthand handler pattern-matches the flat
// array and places "inset" string in the color slot. The compile-time
// path (via lightningcss CSS parser) correctly identifies the inset
// keyword and inherits platform default color. This only affects inset
// shadows without an explicit color, which is uncommon in practice.
expect(component.props.style.boxShadow).toStrictEqual([
{
color: "inset",
inset: true,
offsetX: 0,
offsetY: 0,
blurRadius: 10,
spreadDistance: 5,
color: { semantic: ["label", "labelColor"] },
},
]);
});
Expand All @@ -641,6 +638,7 @@ describe("shadow values from runtime variables", () => {
offsetX: 0,
offsetY: 2,
blurRadius: 4,
spreadDistance: 0,
color: "#000",
},
]);
Expand Down
Loading