✨ Add missing TKET RL actions - #796
flowerthrower wants to merge 3 commits into
Conversation
da0271e to
629877d
Compare
8e325e1 to
bb3ce81
Compare
1ce6b4f to
65c9d98
Compare
|
@coderabbitai full review |
|
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bb3ce81 to
384893d
Compare
65c9d98 to
7c4a965
Compare
384893d to
86e9632
Compare
7c4a965 to
3853b60
Compare
86e9632 to
10b43ad
Compare
3853b60 to
2ba8e5a
Compare
10b43ad to
2afc79b
Compare
7126f5c to
eba24fd
Compare
51bf443 to
30b35b3
Compare
5ff220a to
e21f62c
Compare
461ae89 to
5aad590
Compare
e21f62c to
6f2c985
Compare
5aad590 to
eee4308
Compare
6f2c985 to
6895801
Compare
6895801 to
feac4d3
Compare
f8c08d1 to
8b5a983
Compare
7ae3684 to
42ad441
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
42ad441 to
7090709
Compare
cf070a8 to
9ab6d38
Compare
7923a01 to
29b0b6d
Compare
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Assisted-by: GPT-6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
29b0b6d to
5c8422e
Compare
9ab6d38 to
1264db2
Compare
🤖 AI text below 🤖
Description
Adds the TKET actions used by the paper prototype but missing from the production registry:
KAKDecomposition,GraphPlacement, andNoiseAwarePlacement.The placement actions translate TKET placement maps into complete Qiskit layouts through the existing layout pipeline.
NoiseAwarePlacementreceives mean one- and two-qubit gate errors per node and link, while measurement errors are excluded from those averages and supplied separately as readout errors. Registered TKET layout actions must provide exactly onePlacement.TKET layout and routing actions are masked for circuits containing operations wider than two qubits.
Focused tests cover calibration aggregation, wide-operation masking, real graph and noise-aware placement, KAK semantics, and the public placement boundary. The existing assignment test includes an idle qubit without a register; a small recovery test verifies that failed placement preserves the input circuit and unset layout. These three placement cases pass on current dependencies and minimum Qiskit 2.1.1/Python 3.11. Adjacent layout and registration tests and the lint suite pass.
The inherited VF2 search-budget fix is isolated in #831.
Existing RL models must be retrained because the action schema changes.
It depends on #795 and is followed by #797. No new package dependencies are introduced.
Part of #664
Validation after removing AI routing: all 101 non-training compilation tests pass on the combined stack, and full lint passes. The existing action invariants cover the remaining actions. Fresh CI for this rebased head is pending.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).