🐛 Align RL rewards and terminal outcomes - #830
Draft
flowerthrower wants to merge 5 commits into
Draft
flowerthrower wants to merge 5 commits into
flowerthrower wants to merge 5 commits into
Conversation
This was referenced Sep 22, 2026
Assisted-by: GPT-5.6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Assisted-by: GPT-5.6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
Exercise intermediate rewards, explicit termination, timeouts, traces, and flat/GNN rollout bootstrapping on the combined paper stack. Assisted-by: GPT-6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
flowerthrower
force-pushed
the
fix/rl-horizon-termination
branch
from
September 23, 2026 12:07
52d3e49 to
2ce69cd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Score complete compilations once at termination or the hard horizon; penalize incomplete and aborted attempts without bootstrapping. Expose the remaining pass budget to flat and GNN policies. Assisted-by: GPT-6 via Codex Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
A compilation that exhausts its pass budget now receives the same final reward as explicit termination: the circuit score once if synthesis, layout, and routing are complete, otherwise the existing
no_effect_penalty. This terminal reward replaces the last pass's intermediate reward; earlier improvement rewards and no-effect penalties remain unchanged. Inference raises for incomplete terminal results.Hard-budget endings, pass failures, and pass timeouts terminate without PPO value bootstrapping. External truncations retain their reward and bootstrap from the final observation. Both flat and GNN observations include the normalized remaining pass budget; GNN global features increase from 36 to 37. Models must be retrained. The upgrade guide documents the observation and error-info changes.
Depends on #800 and remains the final draft in the paper stack:
#831 → #755 → #758 → #794 → #795 → #796 → #797 → #798 → #799 → #800 → #830.
Only #831 targets main. Keeping this policy in #830 lets its tests exercise #799's rewards and #800's GNN together.
Validation: all 117 non-training compilation tests and full lint pass, including all 68 RL/GNN tests. Coverage includes complete/incomplete horizons, explicit termination, failure/timeout penalties, unchanged intermediate rewards, remaining-budget observations, traces, flat/GNN PPO bootstrap behavior, and saved GNN inference. Fresh CI remains pending.
AI assistance: Codex implemented the policy, extended the existing tests, and updated the changelog, upgrade guide, and PR description.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).