Repository navigation
ci: run container jobs on ci-base tagged by Dockerfile content - #1693
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 4ecffdf | Commit Preview URL Branch Preview URL |
Oct 24 2026, 10:26 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
iili | 4ecffdf | Commit Preview URL Branch Preview URL |
Oct 24 2026, 10:26 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ast-lol | 4ecffdf | Commit Preview URL Branch Preview URL |
Oct 24 2026, 10:27 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's container jobs ran on
ci-base:latest, which only rebuilt frommain. So a PR that editedDockerfile.citested the old image; #1692 needed two TEMP commits to test itself.scripts/ci-image-tag:df-+ 12 hex of sha256(Dockerfile.ci). The Dockerfile COPYs nothing, so its bytes are the whole input.build-ci-image.ymlis now a reusable workflow. It resolves the tag, and builds and pushes it only if the tag is missing. The weekly and manual runs rebuild it regardless, for security updates.branch.ymlandpublish.ymlcall it first. Every container jobneeds: ci-imageand runs on its output. Unchanged Dockerfile: one short job (login + manifest inspect).:latestis no longer pushed or read. Nothing outside the workflows referenced it.scripts/test-ci-image-tag(intest-deploy) pins the tag: stable, moves with the Dockerfile only, cwd-independent. It also checks that no workflow referencesci-base:latest. It landed first and failed for the right reasons.This PR's own first run exercises the build path:
df-4e954804b359doesn't exist yet.Locally:
scripts/actionlint(and a mutation: a misspelledneeds.ci-image.outputskey fails it),scripts/test-actionlint,scripts/test-ci-image-tag.Fork PRs get a read-only token. They still run when the tag exists; one that edits the Dockerfile can't push its image.
Review panel: not run.
Generated by Claude Code