Repository navigation
graphics: SDL3 and raylib on BCR modules; drop rules_foreign_cc - #1694
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
iili | 2e00c3b | Commit Preview URL Branch Preview URL |
Oct 25 2026, 08:27 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 2e00c3b | Commit Preview URL Branch Preview URL |
Oct 25 2026, 08:27 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ast-lol | 2e00c3b | Commit Preview URL Branch Preview URL |
Oct 25 2026, 08:28 PM |
aaylward
force-pushed
the
claude/great-gauss-lqkl3i
branch
from
October 25, 2026 19:05
72b891c to
43feee6
Compare
…kl3i # Conflicts: # MODULE.bazel.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graphics targets (trill, mandelbrot, tubing, raylib_example) were
manualand broken. Before #1689 the GNU Make bootstrap failed (#1524 item 2); after it, m4 analysis failed, then sdl3's cmake configure. Nothing built them, so nothing noticed. Both libraries now build with nativecc_*rules on BCR modules, with every X11/Wayland/ALSA header from the BCR rather than the host.manualis gone, so CI builds all four (test commits first).SDL3
bazel_dep(name = "sdl3", version = "3.4.18")replaces//bazel/extensions:sdl3.bzl+//bazel/3p:sdl3.BUILD. The label is still@sdl3.single_version_override+sdl3_cc_headers_only_external_includes.patch: sdl3 forwards the headers of the libraries it loads at runtime through acc_headers_onlyrule that keepssystem_includesbut notexternal_includes. Our--features=external_include_pathsfiles external repos' include paths inexternal_includes, sowayland-util.hwent missing. With the feature off, the unpatched module builds. Worth sending upstream.raylib
bazel/3p:raylib.BUILDis now acc_libraryover raylib's seven C modules onbazel_dep(name = "glfw", version = "3.4.0.bcr.4"), as raylib's CMake does withUSE_EXTERNAL_GLFW=ON. Nothing links libGL: GL 3.3 goes through the bundled glad viaglfwGetProcAddress. The binary'sNEEDEDis libc, libm, libdl, libpthread and librt only.single_version_override+rules_bison_runfiles_cstdlib.patch: glfw links xkbcommon, whose parser rules_bison generates. Its runfiles helper callsgetenvwithout<cstdlib>, which LLVM 23's libc++ no longer includes transitively.rules_foreign_ccdropped as a direct dep; nothing else used it.Fallout
scripts/make-git-overrides.shcopiedraylib.BUILDinto its clone only on first creation, so an edited BUILD file silently built the old rules in sandboxes. It now refreshes the copy on every run.Dockerfile.ciandscripts/setup/setup-linuxdrop the SDL-devpackages,cmake,ninja-buildandpkg-config; nothing builds against them now. Since ci: run container jobs on ci-base tagged by Dockerfile content #1693 this PR's CI runs on the image it describes (df-60ea3e596d12).Locally (24.04 sandbox without the SDL
-devpackages): all four targets build under-Werror.bazel test //:buildifier_test //domains/graphics/...passes.raylib_exampleandmandelbrotstart and exit cleanly with no display.scripts/test-make-git-overrides,scripts/test-ci-image-tagandscripts/actionlintpass.MODULE.bazel.lockis from a resolution run without the sandbox overrides.Review panel: not run.