Skip to content

fix: resolve crash when on_csv_write='update' encounters empty column (#1367) #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhoomikakk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: resolve crash when on_csv_write='update' encounters empty column (#1367) #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b9fc7
fix: resolve crash when on_csv_write='update' encounters empty column…
bhoomikakk Sep 19, 2026
55dd452
style: format test_file.py with black
bhoomikakk Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions codecarbon/output_methods/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,13 @@ def out(self, total: EmissionsData, _):
)
df = pd.concat([df, new_df])
else:
update_values = {}
for col, val in dict(total.values).items():
update_values[col] = df[col].dtype.type(val)
df.loc[df.run_id == total.run_id, update_values.keys()] = (
update_values.values()
)
if col in df.columns:
try:
df.loc[df.run_id == total.run_id, col] = val
except (TypeError, ValueError):
df[col] = df[col].astype(object)
df.loc[df.run_id == total.run_id, col] = val
df.to_csv(self.save_file_path, index=False)

def task_out(self, data: List[TaskEmissionsData], experiment_name: str):
Expand Down
18 changes: 18 additions & 0 deletions tests/output_methods/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,24 @@ def test_file_output_out_update_file_exists_one_matchingrows(self):
df = pd.read_csv(os.path.join(self.temp_dir, "test.csv"))
self.assertEqual(df["cpu_power"].iloc[0], 2)

def test_file_output_out_update_empty_column_second_write(self):
file_output = FileOutput("test.csv", self.temp_dir, on_csv_write="update")
# First write: gpu_model is None (written as empty string/NaN)
first_data = self.emissions_data
first_data.gpu_model = None
file_output.out(first_data, None)

df = pd.read_csv(os.path.join(self.temp_dir, "test.csv"))
self.assertTrue(pd.isna(df["gpu_model"].iloc[0]))

# Second write: update with a non-null string for gpu_model
second_data = self.emissions_data
second_data.gpu_model = "NVIDIA RTX 3080"
file_output.out(second_data, None)

df_updated = pd.read_csv(os.path.join(self.temp_dir, "test.csv"))
self.assertEqual(df_updated["gpu_model"].iloc[0], "NVIDIA RTX 3080")

# def test_file_output_out_consistent_column_ordering(self):
# file_output = FileOutput("test.csv", self.temp_dir, on_csv_write="append")
# file_output.out(self.emissions_data, None)
Expand Down
Loading