fix: resolve crash when on_csv_write='update' encounters empty column (#1367) - #1419
Open
bhoomikakk wants to merge 2 commits into
Open
bhoomikakk wants to merge 2 commits into
bhoomikakk wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367
Problem
When
on_csv_write="update"is used,pd.read_csv()infers columns with all missing/empty values asfloat64. On subsequent flushes, attemptingdf[col].dtype.type(val)fails withValueError: could not convert string to floatwhenvalis a string (e.g.gpu_model="NVIDIA RTX...").Solution
df[col].dtype.type(val)and updated DataFrame columns directly.objectdtype (df[col] = df[col].astype(object)) when assigning values to columns whose pandas dtype cannot hold the value (e.g. string values in an all-NaNfloat64column).test_file_output_out_update_empty_column_second_writeintests/output_methods/test_file.py.Verification
tests/output_methods/test_file.py(24 passed).