fix(highlight): highlight in the world the selector resolves in - #42864
Conversation
Custom selector engines registered without contentScript run in the main world, but HighlightController only rendered highlights in the utility world, so such engines could not see page globals and matched nothing. Resolve each selector to its world, set highlights there, and clear both worlds in hideHighlights. Fixes: microsoft#42849
Test results for "tests 1"6 flaky52087 passed, 1252 skipped Merge workflow run. |
Test results for "MCP"4 failed 8688 passed, 1474 skipped Merge workflow run. |
🟡 Nothing here points at this PR, but one failure I can't fully clearHi, I'm the Playwright bot and I triaged the failing CI runs. Three of the four MCP failures are known flakes with history on unrelated SHAs. The fourth — DetailsThis PR touches Pre-existing flake / infra
Uncertain
Triaged by the Playwright bot - agent run |
a8266a5
into
microsoft:main
Summary
contentScriptrun in the main world, butHighlightControlleronly rendered highlights in the utility world, solocator.highlight()matched nothing for themhideHighlights()Fixes #42849