Repository navigation
Conversation
Contributor
|
@panagosg7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133315654. |
panagosg7
force-pushed
the
export-D133315654
branch
from
November 19, 2026 21:48
a425adb to
f3fe746
Compare
panagosg7
added a commit
to panagosg7/react-native
that referenced
this pull request
Nov 19, 2026
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
added a commit
to panagosg7/metro
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 X-link: react/react-native#60165 Pull Request resolved: react#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
added a commit
to panagosg7/react-native
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
added a commit
to panagosg7/metro
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 X-link: react/react-native#60165 Pull Request resolved: react#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
added a commit
to panagosg7/react-native
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
force-pushed
the
export-D133315654
branch
from
November 20, 2026 21:50
f3fe746 to
758dbe4
Compare
Reviewed By: SamChou19815 Differential Revision: D133315654
panagosg7
force-pushed
the
export-D133315654
branch
from
November 20, 2026 21:58
758dbe4 to
1b4310d
Compare
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 X-link: react/react-native#60165 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654 Pull Request resolved: #2255
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Nov 20, 2026
Summary: X-link: meta/relay#5459 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654 Pull Request resolved: #60165
Contributor
|
This pull request has been merged in 989f29c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed By: SamChou19815
Differential Revision: D133315654