Repository navigation
Deploy 0.341.0 to xplat (#2255) - #2255
Conversation
|
@panagosg7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133315654. |
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
Metro review: Looks goodRisk: low · Commit: This PR moves Metro's Flow version from 0.340.0 to 0.341.0 in No findings. Verified
Not run: Benchmarks: this is a devDependency and type-only change with no runtime effect. I did not run Jest, because no runtime code changed. The Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call. |
Summary: X-link: meta/relay#5459 X-link: react/react-native#60165 Pull Request resolved: react#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
6f2dcfe to
2596cf6
Compare
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
Summary: X-link: meta/relay#5459 X-link: react/react-native#60165 Pull Request resolved: react#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
2596cf6 to
0486564
Compare
Summary: X-link: meta/relay#5459 Pull Request resolved: react#60165 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654
Summary: X-link: meta/relay#5459 X-link: react/metro#2255 [changelog](https://github.com/facebook/flow/blob/main/Changelog.md) ## Library definitions Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D133315654 Pull Request resolved: #60165
Summary:
X-link: meta/relay#5459
X-link: react/react-native#60165
changelog
Library definitions
Flow 0.341.0 rejects the explicit exact object syntax
{| |}and unnamed function type parameters, and checks type applications inside generic definitions. Relay'sflow-typed/definitions for Babel, chalk and Jest now write exact objects as{ }(objects are exact by default, so the meaning is unchanged), and the second parameter of Babel'straverseis named. In the sharedchild_processdefinition used by Metro and React Native,MaybeStreaminfersEfrom the optionalstdiooption, soEincludesvoid; its indexed accesses now readNonNullable<E>[FD].Changelog: [Internal]
Reviewed By: SamChou19815
Differential Revision: D133315654