Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Refs #42.
Keep a failed Mini App start visible as an actionable “not opened” state after its error toast is dismissed. An explicit retry uses the normal open operation; polling does not restart a failed presentation. Only
OWNED_ELSEWHEREreceives the cross-client close-and-retry hint. Generic preparation errors retain their own message without inferring ownership.This is a WebUI recovery-state fix, not a force-takeover feature or a change to the wire contract, runtime ownership, or underlying
reasonCodediagnostics. Stop and lease failures do not create a failed-start state. The owning ADR and presentation inventory are updated.Validation
Validation was performed on the exact patch against base
74b283209e2ffd50f9cad9c66fda864b6605bfd4in Linux with Node.js 24; publication uses the same SHA-256-verified patch without further code changes.git diff --check.OWNED_ELSEWHERE, toast dismissal, repeated refusal and explicit successful retry. The browser scenario did not run: the local harness was blocked at IPC socket setup withEPERMbefore Chromium testing began.perf:fullrun. No full aggregate verification is claimed.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable. This patch changes only existing files and existing test suites, so no source inventory or suite-list regeneration is required.Maintainer handoff
Publication scope or license changes: none. The patch is limited to existing WebUI application/presentation code, tests, its owning ADR and the reviewed presentation fingerprint.
Shared-source port: not needed. This is a fork-local WebUI change, submitted only to
mcode-webui/minimax-code.Please verify the added browser scenario in an environment that can start the fixture server, then check real Desktop/WebUI ownership refusal and recovery before treating this as end-to-end acceptance. The underlying preparation failure diagnosis remains outside this patch.
中文说明
变更
关联 #42,本 PR 不关闭该问题。Mini App 启动失败后,关闭错误提示也会保留「应用尚未打开」和「重试打开应用」按钮。重试必须由用户主动触发,走常规打开流程;后台轮询不会自动重启。只有宿主明确返回
OWNED_ELSEWHERE时才提示先在其他客户端关闭应用;其他准备失败保留原有错误信息,不判断为跨端占用。本 PR 只修复 WebUI 的失败恢复界面,不做强制接管,不改变通信协议、运行时归属机制或底层
reasonCode诊断。停止失败和页面租约失败不会生成启动重试状态。已同步对应 ADR 和界面组件清单。验证
74b283209e2ffd50f9cad9c66fda864b6605bfd4的同一份补丁验证;发布时核对了补丁 SHA-256,未额外改代码。git diff --check。EPERM未能启动,这些浏览器断言未在本地执行。三平台结果以本 PR 对应的 GitHub CI 为准。perf:full,未在本地运行完整验证。未在真实 Desktop + WebUI 并行场景、Windows/macOS 原生运行时或在线服务上验收;模拟测试不能替代真机结果。发布检查与维护者交接