Skip to content

fix(webui): preserve Mini App preparation refusal reasons - #53

Open
Fectivnfy112357 wants to merge 5 commits into
mainfrom
fix/miniapp-preparation-diagnostics
Open

Fectivnfy112357 wants to merge 5 commits into
mainfrom
fix/miniapp-preparation-diagnostics

Conversation

@Fectivnfy112357

@Fectivnfy112357 Fectivnfy112357 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Change

Refs #42. Preserve the structured Mini App preparation reason through WebUI's open operation. The existing primary error code stays intact. The server records the primary code and validated reason without including the cause or launch data. The client includes the reason in the refusal and uses the existing ownership presentation when the reason is OWNED_ELSEWHERE.

This PR covers the diagnostics path. #47 separately covers the standalone error and retry state. This branch is stacked on #50 for the committed source inventory assets. Retarget it to main after #50 lands.

Validation

  • The added dispatcher test failed before implementation because the error frame lacked reasonCode.
  • 74 tests passed across the WebUI wire envelope, transport, and Mini App client state. Coverage includes direct and wrapped ownership refusal and preservation of the original primary code.
  • Public source, generated paths and WebUI internal dependency checks passed. Full verification has been started.
  • No real macOS Desktop + WebUI MiniMax Bot session or group mention was tested. This change preserves the diagnostic signal for that run and does not identify the cause of the original incident.
  • Performance: basic.

Publication and contribution checks

No new public file paths. AOCI updates include the four changed implementation entries and reconcile observed build outputs missing from the clean worktree. No project account data or credentials were used in these tests.

Follow-up validation on 78335bc

  • The initial hosted type check found that the client event channel's frame type lacked the optional field. Added it to that frame contract. The Linux client TypeScript check now passes with workspace dependency links present.
  • A real-host integration failed on the initial patch because the child runner's RUNNER_START_FAILED was available only on the immediate cause. The WebUI dispatcher now uses that cause's stable code when the top-level reason is absent, without sending the cause object. The same test passed over a real loopback socket.
  • All 80 tests passed across the real Mini App flow, wire envelope, transport and client-state suites. The real flow uses an isolated local fixture package, not the reported macOS Desktop and MiniMax Bot combination.

@Fectivnfy112357
Fectivnfy112357 changed the base branch from fix/confirmed-webui-release-issues to main November 20, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant