Skip to content

fix(wallets): render Ibex transaction history in the account display currency (#284) #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nul-quill wants to merge 1 commit into from
Closed

fix(wallets): render Ibex transaction history in the account display currency (#284) #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 38 additions & 34 deletions src/app/accounts/get-transactions-for-account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,38 @@
import { AccountValidator } from "@domain/accounts"
import { RepositoryError } from "@domain/errors"
import { WalletsRepository } from "@services/mongoose"

import { getTransactionsForWallets } from "../wallets"
import { PartialResult } from "../partial-result"

export const getTransactionsForAccountByWalletIds = async ({
account,
walletIds,
paginationArgs,
}: {
account: Account
walletIds: WalletId[]
paginationArgs?: PaginationArgs
}): Promise<PartialResult<PaginatedArray<BaseWalletTransaction>>> => {
const walletsRepo = WalletsRepository()

const wallets: Wallet[] = []
for (const walletId of walletIds) {
const wallet = await walletsRepo.findById(walletId)
if (wallet instanceof RepositoryError) return PartialResult.err(wallet)

const accountValidator = AccountValidator(account)
const isActive = accountValidator.isActive()
if (isActive instanceof Error) return PartialResult.err(isActive)
const validateWallet = accountValidator.validateWalletForAccount(wallet)
if (validateWallet instanceof Error) return PartialResult.err(validateWallet)

wallets.push(wallet)
}

return getTransactionsForWallets({ wallets, paginationArgs })
}
import { AccountValidator } from "@domain/accounts"
import { RepositoryError } from "@domain/errors"
import { WalletsRepository } from "@services/mongoose"

import { getTransactionsForWallets } from "../wallets"
import { PartialResult } from "../partial-result"

export const getTransactionsForAccountByWalletIds = async ({
account,
walletIds,
paginationArgs,
}: {
account: Account
walletIds: WalletId[]
paginationArgs?: PaginationArgs
}): Promise<PartialResult<PaginatedArray<BaseWalletTransaction>>> => {
const walletsRepo = WalletsRepository()

const wallets: Wallet[] = []
for (const walletId of walletIds) {
const wallet = await walletsRepo.findById(walletId)
if (wallet instanceof RepositoryError) return PartialResult.err(wallet)

const accountValidator = AccountValidator(account)
const isActive = accountValidator.isActive()
if (isActive instanceof Error) return PartialResult.err(isActive)
const validateWallet = accountValidator.validateWalletForAccount(wallet)
if (validateWallet instanceof Error) return PartialResult.err(validateWallet)

wallets.push(wallet)
}

return getTransactionsForWallets({
wallets,
paginationArgs,
displayCurrency: account.displayCurrency,
})
}
Loading