Repository navigation
Conversation
…currency - thread the account displayCurrency into getTransactionsForWallets so the settlement display label/conversion is no longer hardcoded to USD - build settlementDisplayPrice with the display currency's major exponent so base/offset stay consistent with the settlementPrice derivation - convert each row with its own exchangeRateCurrencySats and round instead of floor, so sub-cent BTC receipts no longer collapse to 0 - resolvers (btc/usd/usdt wallet) and getTransactionsForAccount pass the currency from the GraphQL/account context; CSV export keeps the optional arg Refs lnflash#284
Author
|
Handle: nul-quill. Payout wallets: Solana USDC BdznDjc4xwt5Y6WJT5UnrFQzDptka8YnC9oqmmkKpwkd, TRC20 TNEHCVwR2aPMrj5AKfWCQ2rFL3bEDQmsg7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads the account displayCurrency into getTransactionsForWallets so the Ibex transaction history is labelled and converted in the configured currency instead of hardcoded USD; builds settlementDisplayPrice with the display currency major exponent so base/offset match the settlementPrice derivation; converts each row with its own exchangeRateCurrencySats and rounds instead of flooring so sub-cent BTC receipts no longer collapse to 0. CSV export path keeps the arg optional. Covers all three points in #284. Tests: jest --config ./test/flash/unit/jest.config.js -> 46 suites / 512 tests passed.