Skip to content

Build AMDGPU profile runtime in HIP buildbot#868

Merged
yxsamliu merged 1 commit into
llvm:mainfrom
yxsamliu:amd/dev/yaxunl/hip-build-offload-pgo
Jun 15, 2026
Merged

Build AMDGPU profile runtime in HIP buildbot#868
yxsamliu merged 1 commit into
llvm:mainfrom
yxsamliu:amd/dev/yaxunl/hip-build-offload-pgo

Conversation

@yxsamliu

@yxsamliu yxsamliu commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The HIP buildbot now builds the AMDGPU profile runtime used by HIP offload PGO.

@yxsamliu

Copy link
Copy Markdown
Contributor Author

This is needed for the llvm-test-suite HIP offload PGO test: llvm/llvm-test-suite#366

That test needs the AMDGPU profile runtime to be available in the HIP buildbot toolchain.

@yxsamliu yxsamliu requested review from jmmartinez and jplehr June 10, 2026 14:59
@yxsamliu

Copy link
Copy Markdown
Contributor Author

The failing llvm-zorg litmus test looks unrelated to this PR. It fails in buildbot checkconfig due to a syntax error in buildbot/osuosl/master/config/builders.py, introduced by 3f08244. The same error is present on current main. This PR only changes hip-build.sh.

@jplehr jplehr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term, I think we want to move this build recipe over to a CMake cache like we do with the other buildbots we maintain.

Objections?

@yxsamliu

Copy link
Copy Markdown
Contributor Author

No objection from me. Moving this to a CMake cache sounds cleaner and matches the other AMDGPU/offload bots.

For this PR, I would prefer to keep the change small and only enable the AMDGPU profile runtime. We can do the cache migration as a follow-up.

@yxsamliu yxsamliu merged commit 336ab19 into llvm:main Jun 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants