Repository navigation
fix(native): line Pulls up on the sidebar's spacing, and write the design language down - #998
Merged
Merged
Conversation
…-off in the header Resolve conflicts and Fix checks leave the ⋯ menu for a button beside Merge. The header and its strips sit on the island's 8px edge, the body at 18px like a sidebar card, and rows hover-fill inside the edge with rounded corners. Thread actions use the window's SM buttons, and the hunk a thread quotes sits in a block of its own on the background, its tabs expanded: the fonts draw a missing-glyph box for one.
Tokens, button sizes, where actions go and the island's spacing, measured from the sidebar and Settings, so a new screen starts from the pattern instead of finding it in review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review fixes on the Pulls screen from #992, and a
native/DESIGN.mdso the next screen starts from these patterns instead of rediscovering them in review.Pulls
pullsRowEdge+pullsRowPadX). List and panel rows hover-fill inside the edge withRadiusMD, like a sidebar card; the seams between PR rows stay.SizeXStoSizeSM, the window's size for screen actions.Background, apart from the comments onSidebar, with added and removed rows tinted. Tabs expand to four spaces: the fonts have no glyph for a tab and drew a missing-glyph box.Docs
native/DESIGN.md: open surfaces over boxes, tokens, units, semantic color, button sizes, where actions go, the island's edge and screen layout, measured from the sidebar and Settings. The spacing is shared; each screen keeps its own look.CLAUDE.mdpoints to it under "Where things are written down".Test plan
native/:gofmt -l .,go vet ./...,go test ./...go test ./internal/patchnotes/