Skip to content

style(native): improve pull request Markdown readability - #997

Merged
omartelo merged 2 commits into
lichdotdev:mainfrom
JoJowAkaGioGiow:feat/improve-pull-request-visibility
Oct 30, 2026
Merged

omartelo merged 2 commits into
lichdotdev:mainfrom
JoJowAkaGioGiow:feat/improve-pull-request-visibility

Conversation

@JoJowAkaGioGiow

Copy link
Copy Markdown
Contributor

Summary

  • Improve contrast, heading hierarchy and spacing in pull request descriptions, comments and Markdown previews.
  • Align wrapped list items with their text and give inline code a subtle background.
  • Refresh cached Markdown when the interface or editor font changes.

Verification

  • Backend and native: gofmt -l ., go vet ./... and go test ./... passed.
  • Inspected native renders in light and dark themes, including wrapped lists and inline code.
  • Backend tests used LC_ALL=C and Chrome for Testing 155; native tests used isolated font data. The installed Helium 0.20.1.1 also reproduces download navigation failures on unchanged main.

@omartelo omartelo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, the readability gain is real. Two notes against the design language that #998 writes down in native/DESIGN.md (not merged yet, so this is a heads-up rather than a rule you broke).

The doc keeps text on Tailwind's scale (ui.TextXS / TextSM / TextBase) and radius on ui.RadiusSM / MD / LG, with anything off the scale as a named constant beside the screen that uses it. Both deviations below may well be the right call for long-form Markdown; if so, the doc is what should move. Once #998 lands, a line in DESIGN.md saying where and why Markdown reads at 15sp (and what its inline code looks like) would let the next screen that renders prose follow it instead of rediscovering it.

Heads-up too: this PR and #998 both edit CHANGELOG.md [Unreleased] › Changed around the Pulls entry, so whichever merges second resolves a small conflict there (keep both lines).

@omartelo

Copy link
Copy Markdown
Collaborator

Thanks a lot for this, @JoJowAkaGioGiow! The Markdown in pull requests reads much better now. Merging.

@omartelo
omartelo merged commit 6f99642 into lichdotdev:main Oct 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants