Repository navigation
Conversation
omartelo
left a comment
There was a problem hiding this comment.
Thanks for this, the readability gain is real. Two notes against the design language that #998 writes down in native/DESIGN.md (not merged yet, so this is a heads-up rather than a rule you broke).
The doc keeps text on Tailwind's scale (ui.TextXS / TextSM / TextBase) and radius on ui.RadiusSM / MD / LG, with anything off the scale as a named constant beside the screen that uses it. Both deviations below may well be the right call for long-form Markdown; if so, the doc is what should move. Once #998 lands, a line in DESIGN.md saying where and why Markdown reads at 15sp (and what its inline code looks like) would let the next screen that renders prose follow it instead of rediscovering it.
Heads-up too: this PR and #998 both edit CHANGELOG.md [Unreleased] › Changed around the Pulls entry, so whichever merges second resolves a small conflict there (keep both lines).
|
Thanks a lot for this, @JoJowAkaGioGiow! The Markdown in pull requests reads much better now. Merging. |
Summary
Verification
gofmt -l .,go vet ./...andgo test ./...passed.LC_ALL=Cand Chrome for Testing 155; native tests used isolated font data. The installed Helium 0.20.1.1 also reproduces download navigation failures on unchangedmain.