Skip to content

feat: enable circular RoPE for qwen2.1 #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stduhpf wants to merge 2 commits into from
Closed

feat: enable circular RoPE for qwen2.1 #2036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb5962
feat: enable circular RoPE for qwen2.1
stduhpf Sep 23, 2026
e864777
format
stduhpf Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/model/diffusion/qwen_image_2_1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,26 @@ namespace Qwen {
auto run = [&](const QwenImage21PrefixCache& active_cache) {
const bool cached = active_cache.mode == QwenImage21PrefixCache::Mode::REUSE;
const auto first_position = layout.positions.begin() + (cached ? layout.prefix_length : 0);
pe_data = Rope::embed_nd(std::vector<std::vector<float>>(first_position, layout.positions.end()), 1, 10000.f, config.axes_dim);
std::vector<std::vector<int>> wrap_dims;
if ((circular_y_enabled || circular_x_enabled) && config.axes_dim.size() >= 3) {
int h_len = shapes.back().first;
int w_len = shapes.back().second;
if (h_len > 0 && w_len > 0) {
size_t pos_len = layout.positions.size();
wrap_dims.assign(config.axes_dim.size(), std::vector<int>(pos_len, 0));
size_t cursor = layout.prefix_length;
size_t img_tokens = static_cast<size_t>(h_len) * static_cast<size_t>(w_len);
for (size_t token_i = 0; token_i < img_tokens; ++token_i) {
if (circular_y_enabled) {
wrap_dims[1][cursor + token_i] = h_len;
}
if (circular_x_enabled) {
wrap_dims[2][cursor + token_i] = w_len;
}
}
}
}
pe_data = Rope::embed_nd(std::vector<std::vector<float>>(first_position, layout.positions.end()), 1, 10000.f, config.axes_dim, wrap_dims);
mask_data.clear();
if (!cached) {
for (const auto& segment : layout.segments) {
Expand Down
Loading