Conversation
stduhpf
force-pushed
the
qwen-circular
branch
from
September 23, 2026 15:26
8340bcb to
bdb5962
Compare
Owner
|
Thanks for your contribution! This has been superseded by #2039. Having to modify RoPE every time to accommodate the circular logic was getting pretty cumbersome, so I abstracted it into a generic post-processing step instead. This should make integrating new models much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve support for
--circular,--circularx, and--circularyflags with Qwen-Image 2.1.Related Issue / Discussion
#914
Additional Information
sd-cli.exe --diffusion-model models\qwen_image_2.1-Q8_0.gguf --llm 'models\Qwen\Qwen3-VL-8B-Instruct-Q4_K_M.gguf' --llm_vision 'models\Qwen\mmproj-Qwen3VL-8B-Instruct-Q8_0.gguf' --vae models\vae\wan-qwen\qwen_image_2.1_vae_bf16.safetensors --cfg-scale 3.5 --steps 20 --seed 42 --vae-conv-direct --prompt-file prompt-file.txt -r assets\cat_with_sd_cpp_42.png -W 1024 -H 512 --diffusion-fa --extra-sample-args guidance_schedule=1x7prompt-file.txt:
Without


--circularx, visible seam as expectedMaster branch, with


--circularx, lots of artifacts around the seam, even more visiblePR, with


--circularx, seamlessNote that the overall quality of the generation is slightly degraded, the room no longer has 4 nice straight walls when cirular tiling is enabled, but artifacts and seams are gone.
Checklist