Skip to content
This repository was archived by the owner on Nov 16, 2025. It is now read-only.

Add non-potable water sources#6

Merged
jsleroy merged 3 commits into
jsleroy:mainfrom
abelstuker:main
Aug 11, 2025
Merged

Add non-potable water sources#6
jsleroy merged 3 commits into
jsleroy:mainfrom
abelstuker:main

Conversation

@abelstuker

Copy link
Copy Markdown
Contributor

Motivation

Hikers often carry water filters, especially on longer routes where potable water sources may be sparse. In such cases, access to non-potable water sources becomes valuable. Therefore, it could be very useful to include these non-potable water sources in the generated GPX.

Added features

  • add non-potable water sources of all types
  • new location marker icon
  • location marker color differentiation between potable (blue) and non-potable (orange) water sources
  • add watering_places as potential water source (intended for animals, but some are explicitly marked as drinkable)

Comment thread CHANGELOG.md
@jsleroy

jsleroy commented Aug 5, 2025

Copy link
Copy Markdown
Owner

LGTM.
You should only remove the update of the CHANGELOG commit and that should be good and ready to merge.

@abelstuker

Copy link
Copy Markdown
Contributor Author

Aah yeah mb, has been reverted now!

@abelstuker abelstuker requested a review from jsleroy August 10, 2025 08:01
@jsleroy

jsleroy commented Aug 10, 2025

Copy link
Copy Markdown
Owner

Sorry forgot to reply.
Could you instead remove commit 510fb05 and not introduce a revert commit ?
The reason is that the CHANGELOG is automatically generated from the commit history and I'm not sure how it would look like in such case.

@abelstuker

Copy link
Copy Markdown
Contributor Author

Aah yes I see, sorry. This is fixed now!

@jsleroy

jsleroy commented Aug 11, 2025

Copy link
Copy Markdown
Owner

Can you run the precommit checks and fix reported issues ? The CI is failing so I can't merge your PR right now.

@abelstuker

Copy link
Copy Markdown
Contributor Author

👍 I amended 223de49 to not further pollute the generated changelog.

@jsleroy jsleroy merged commit f25ec78 into jsleroy:main Aug 11, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants