This repository was archived by the owner on Nov 16, 2025. It is now read-only.
Add non-potable water sources#6
Merged
Merged
Conversation
jsleroy
reviewed
Aug 5, 2025
Owner
|
LGTM. |
Contributor
Author
|
Aah yeah mb, has been reverted now! |
Owner
|
Sorry forgot to reply. |
Contributor
Author
|
Aah yes I see, sorry. This is fixed now! |
Owner
|
Can you run the precommit checks and fix reported issues ? The CI is failing so I can't merge your PR right now. |
Contributor
Author
|
👍 I amended 223de49 to not further pollute the generated changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hikers often carry water filters, especially on longer routes where potable water sources may be sparse. In such cases, access to non-potable water sources becomes valuable. Therefore, it could be very useful to include these non-potable water sources in the generated GPX.
Added features