Skip to content

[UNFY-409] Upgrade flutter_lints and pigeon, raise the SDK floor - #71

Merged
jake-dev-99 merged 7 commits into
mainfrom
chore/unfy-409-upgrade-lints-pigeon-sdk-floor
Nov 18, 2026
Merged

jake-dev-99 merged 7 commits into
mainfrom
chore/unfy-409-upgrade-lints-pigeon-sdk-floor

Conversation

@jake-dev-99

@jake-dev-99 jake-dev-99 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Part of UNFY-408 (dependency upgrade across Unify and the simple plugins). Closes UNFY-409.

What changed

  • flutter_lints 5 → 6 in all six packages and the example, pinned exactly (6.0.0).
  • pigeon 22 → 30 (30.0.4, exact) in the Android, iOS and macOS packages; Kotlin, Swift and Dart glue regenerated.
  • Every package now requires Flutter 3.47.7 / Dart 3.13 (the Unify app's floor). Cut the next release as a major version (2.0.0): dropping SDKs the current release accepts is breaking, and every Unreleased changelog entry says so. This narrows the supported SDK range, most of all for the platform interface and web packages (previously Flutter 3.24 / Dart 3.6).
  • Pigeon 30 turns @async host methods into suspend / async functions. The definitions now use @asyncCallback, which keeps the callback signatures the hand-written Kotlin and Swift implement. No native implementation code changed.
  • The regenerated Dart imports package:meta, so meta is a declared dependency of the Android, iOS and macOS packages.
  • Removed the deprecated unnecessary_await_in_return lint.

Flutter 3.50

Stable moved to Flutter 3.50 while this PR was open, and CI runs on stable. 3.50 deprecates package:flutter/material.dart and needs AGP 9.1.1 / Gradle 9.3.1, so:

  • The example imports package:material_ui (1.11.1).
  • The example's Android build moves to AGP 9.4.1 and Gradle 9.8.1.

The library code itself needs nothing from 3.50, so the package floor stays at 3.47.7.

Verification (local, Flutter 3.50.0)

  • flutter analyze --no-fatal-warnings: no issues in every package and the example.
  • flutter test: passes in every package.
  • flutter pub publish --dry-run: 0 warnings in every package.
  • Lockfiles: regenerated from scratch, then analyze, tests and Pigeon regeneration re-run against them with no changes. No pubspec.lock in any published archive.
  • Android: example APK builds, and ./gradlew :simple_permissions_android:testDebugUnitTest passes.
  • macOS: the regenerated Swift compiles inside the Unify app's macOS build on 3.50. The build stops only at the app's own FlutterFire symbol-upload step, because the flutterfire CLI is not installed on this machine.
  • iOS: compiled on Flutter 3.47.x before 3.50 shipped. Not re-run on 3.50.
  • python3 -m unittest discover -s tool -p 'test_*.py': 142 tests OK, 4 skipped.

Not fixed here: example/test/widget_test.dart fails on a layout overflow, the same as on main. Tracked in UNFY-416.

Reviews

Simple Zen canon review (sz-code-review, quick then full, at this head): PASS, no findings.

Lockfiles (CQS-DEP-02): fixed. Every package's and the example's pubspec.lock is now committed, regenerated on Flutter 3.50 the way CI resolves it (through the tracked pubspec_overrides.yaml links). Trade-off: CI now tests the locked versions instead of the newest versions the constraints allow, so newer dependencies arrive through a committed flutter pub upgrade. pub leaves pubspec.lock out of published packages, and Deploy's pub get against hosted packages only rewrites the runner's copy. osv-scanner finds no advisories in the committed lockfiles. AGENTS.md now says when to commit lockfile changes.

Two items are left to a canon amendment Jake is handling outside this PR (not repo ADRs):

  1. Published libraries keep caret ranges for runtime dependencies such as meta: ^1.17.0. Dev dependencies are pinned exactly.
  2. How the CQS-CLR rules apply to generated code (the Pigeon *.g.* output).

/code-review ran on every commit. Outcomes:

  • Regenerated Dart was unformatted → fixed.
  • docs/ENUMS_TO_SEALED.md still showed @async → fixed.
  • material_ui sat after a stray blank line in the example's pubspec → fixed.
  • The library buildscript still pins AGP 9.1.0, below 3.50's 9.1.1 → refuted. A consumer build runs the app's AGP (the example and the Unify app both run 9.4.1, and both build on 3.50), so the library pin never decides the version.
  • The example floor stays 3.47.7 while the toolchain moved to 3.50 → refuted. The example's only new dependency, material_ui, supports Flutter 3.47.0 or later, and AGP/Gradle are toolchain choices, not pub constraints.
  • cupertino_icons is unused in the example → refuted. It is the template dependency of an unpublished example, so removing it is churn outside this upgrade.
  • Exact flutter_lints / pigeon pins are repeated in seven pubspecs → refuted. They move together in one PR, as here; the pub-workspace move (UNFY-413) is where they get a single home.
  • SDK floor raise on the interface and web packages is larger than their code needs → intended. UNFY-408 sets a single floor across the plugins.

Review conversations

  • Sourcery and CodeRabbit: the SDK floor raise needs a major version → accepted (operator decision). The changelogs mark it Breaking; the release coordinator moves the implementations onto the new interface major in the same batch.

🤖 Generated with Claude Code

Summary by Sourcery

Raise the SDK floor and refresh package tooling and generated platform channels for the next major release.

Enhancements:

  • Raise the minimum supported Flutter and Dart versions across all packages, requiring a major release.
  • Upgrade Pigeon-generated platform channel code for Android, iOS, and macOS while preserving existing native callback interfaces.
  • Upgrade lint tooling across the packages and example, remove the deprecated await lint, and declare the generated code’s meta dependency.

Build:

  • Update the example Android build to newer AGP and Gradle versions and replace the deprecated Flutter material import with material_ui.

Documentation:

  • Update enum-to-sealed migration documentation for the Pigeon callback annotation.

Summary by CodeRabbit

  • Compatibility
    • Minimum supported versions are now Flutter 3.47.7 and Dart 3.13 across the packages and example. Earlier versions are no longer supported.
    • Updated the example app’s Android build tooling.
  • Bug Fixes
    • Corrected punctuation in permission error descriptions on iOS and macOS.
    • Improved handling of missing or null values in iOS and macOS permission responses.

jake-dev-99 and others added 3 commits November 17, 2026 23:00
Bump flutter_lints to 6 and pigeon to 30, and raise every package to
Flutter 3.47.7 / Dart 3.13. Pigeon 30 turns @async host methods into
suspend/async functions, so the definitions switch to @asynccallback to
keep the callback signatures the native implementations use. The
regenerated Dart imports package:meta, now a declared dependency of the
Android, iOS and macOS packages.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… doc

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change raises minimum Dart and Flutter versions across the repository, updates tooling, and changes selected Pigeon annotations and generated platform-channel code. The example app and lockfile guidance are also updated.

Changes: SDK and platform-channel updates

Layer / File(s) Summary
SDK requirements and tooling
pubspec.yaml, example/pubspec.yaml, packages/*/pubspec.yaml, CHANGELOG.md, packages/*/CHANGELOG.md, analysis_options.yaml, packages/*/analysis_options.yaml
Root, example, and package SDK constraints now require Dart ^3.13.0 and Flutter >=3.47.7. Development dependencies change, meta is added to the Android, iOS, and macOS packages, the unnecessary_await_in_return lint rule is removed, and unreleased changelog entries are added.
Pigeon callback annotations
packages/simple_permissions_{android,ios,macos}/pigeon.dart, docs/ENUMS_TO_SEALED.md
Selected asynchronous host API methods use @asyncCallback instead of @async. Their signatures remain unchanged. The documentation records the annotation change for two iOS methods.
Generated platform-channel bindings
packages/simple_permissions_android/android/src/main/kotlin/io/simplezen/simple_permissions_android/Permissions.g.kt, packages/simple_permissions_ios/ios/simple_permissions_ios/Sources/simple_permissions_ios/PermissionsIos.g.swift, packages/simple_permissions_macos/macos/simple_permissions_macos/Sources/simple_permissions_macos/PermissionsMacos.g.swift
Generated code identifies Pigeon v30.0.4. Android wraps results and errors through PermissionsPigeonUtils, and FlutterError now extends RuntimeException. The iOS and macOS bindings update error details types, null checks, and error formatting.
Example app setup
example/pubspec.yaml, example/lib/main.dart, example/android/gradle/wrapper/gradle-wrapper.properties, example/android/settings.gradle.kts
The example adds material_ui and imports it in place of Flutter's Material library. The Gradle wrapper and Android application plugin versions are updated.
Lockfile tracking guidance
.gitignore, AGENTS.md
The ignore rules allow pubspec.lock files to be tracked. Contributor guidance describes when to commit package and example lockfiles and states that published packages exclude them.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: Minimal · up to c27ef

This PR upgrades lint and Pigeon tooling and raises the minimum Flutter and Dart versions. The raised floor is documented as a breaking change in every package changelog, with a major release planned. No actionable merge risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two of the main changes: the flutter_lints and Pigeon upgrades, and the raised SDK floor. The objectives also cover the lint rule removal, the example app's Material package switch, an…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two of the main changes: the flutter_lints and Pigeon upgrades, and the raised SDK floor. The objectives also cover the lint rule removal, the example app's Material package switch, and the AGP/Gradle upgrades, which the title leaves out. The title is specific and tied to the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aa5b59e0-b568-4171-a338-0f61a03b8c3c
Commits

Reviewing files that changed from the base of the PR and between f13751f and c27efaf.

Files ignored due to path filters: 7

  • example/pubspec.lock is excluded by !**/*.lock
  • packages/simple_permissions_android/pubspec.lock is excluded by !**/*.lock
  • packages/simple_permissions_ios/pubspec.lock is excluded by !**/*.lock
  • packages/simple_permissions_macos/pubspec.lock is excluded by !**/*.lock
  • packages/simple_permissions_platform_interface/pubspec.lock is excluded by !**/*.lock
  • packages/simple_permissions_web/pubspec.lock is excluded by !**/*.lock
  • pubspec.lock is excluded by !**/*.lock
Files selected for processing: 2

  • .gitignore
  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T04:05:34.713560Z 4f48e49 PR opened
🔒 Security Review ✅ Completed 2026-11-18T04:06:59.578044Z 4f48e49 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sourcery-ai

sourcery-ai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

API

Update the Pigeon host API definitions and their generated Dart, Kotlin, and Swift channel code together, preserving the native callback signatures under Pigeon 30.

  • packages/simple_permissions_android/android/src/main/kotlin/io/simplezen/simple_permissions_android/Permissions.g.kt L16-35, L120-123, L157-160 (+17 small edits)
  • packages/simple_permissions_android/lib/src/generated/permissions.g.dart L1-34, L83-99, L104-120 (+22 small edits)
  • packages/simple_permissions_android/pigeon.dart L19-53 (7 small edits)
  • packages/simple_permissions_ios/ios/simple_permissions_ios/Sources/simple_permissions_ios/PermissionsIos.g.swift L58-69 (+5 small edits)
  • packages/simple_permissions_ios/lib/src/generated/permissions_ios.g.dart L1-34, L64-75, L92-101 (+9 small edits)
  • packages/simple_permissions_ios/pigeon.dart L24, L30, L37-41
  • packages/simple_permissions_macos/lib/src/generated/permissions_macos.g.dart L1-34, L64-75, L92-101 (+9 small edits)
  • packages/simple_permissions_macos/macos/simple_permissions_macos/Sources/simple_permissions_macos/PermissionsMacos.g.swift L58-69 (+5 small edits)
  • packages/simple_permissions_macos/pigeon.dart L24, L30, L37-41

UI

Switch the example app to the Flutter 3.50-compatible material_ui import.

  • example/lib/main.dart L1

Configuration

Raise the SDK floors, update and pin lint and Pigeon tooling, and declare meta where regenerated code requires it.

  • example/pubspec.yaml L6-8, L22, L29
  • packages/simple_permissions_android/pubspec.yaml L14-15, L20, L25-26
  • packages/simple_permissions_ios/pubspec.yaml L14-15, L20, L26-27
  • packages/simple_permissions_macos/pubspec.yaml L14-15, L20, L26-27
  • packages/simple_permissions_platform_interface/pubspec.yaml L13-14, L24
  • packages/simple_permissions_web/pubspec.yaml L14-15, L28
  • pubspec.yaml L15-16, L30

Remove the deprecated lint rule from each package's analyzer configuration.

  • analysis_options.yaml L28 (removed lines)
  • packages/simple_permissions_android/analysis_options.yaml L26 (removed lines)
  • packages/simple_permissions_ios/analysis_options.yaml L29 (removed lines)
  • packages/simple_permissions_macos/analysis_options.yaml L25 (removed lines)
  • packages/simple_permissions_platform_interface/analysis_options.yaml L22 (removed lines)
  • packages/simple_permissions_web/analysis_options.yaml L22 (removed lines)

Update the example Android build tooling and stop ignoring lockfiles now that they are committed.

  • .gitignore L20, L43 (removed lines)
  • example/android/gradle/wrapper/gradle-wrapper.properties L5
  • example/android/settings.gradle.kts L21

Documentation

Record the breaking SDK-floor increase in the unreleased changelogs and update the Pigeon annotation in the migration guide.

  • AGENTS.md L49-54
  • CHANGELOG.md L1-4
  • docs/ENUMS_TO_SEALED.md L259-260
  • packages/simple_permissions_android/CHANGELOG.md L1-5
  • packages/simple_permissions_ios/CHANGELOG.md L1-5
  • packages/simple_permissions_macos/CHANGELOG.md L1-5
  • packages/simple_permissions_platform_interface/CHANGELOG.md L1-4
  • packages/simple_permissions_web/CHANGELOG.md L1-4

Lock files and vendored code

Commit the resolved dependency lockfiles for the root package, example, and each package.

  • example/pubspec.lock L1-368
  • packages/simple_permissions_android/pubspec.lock L1-380
  • packages/simple_permissions_ios/pubspec.lock L1-380
  • packages/simple_permissions_macos/pubspec.lock L1-380
  • packages/simple_permissions_platform_interface/pubspec.lock L1-221
  • packages/simple_permissions_web/pubspec.lock L1-241
  • pubspec.lock L1-269

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packages/simple_permissions_platform_interface/pubspec.yaml" line_range="13-14" />
<code_context>

 environment:
-  sdk: ^3.7.2
+  sdk: ^3.13.0
   # android.builtInKotlin=true (android/gradle.properties) needs Flutter 3.47.
-  flutter: '>=3.47.0'
+  flutter: '>=3.47.7'

 # Dependencies specify other packages that your package needs in order to work.
</code_context>
<issue_to_address>
**Older SDK consumers lose compatibility**

When a consumer on the previously supported SDK range tries to adopt the next minor release, the new SDK constraints reject consumers on the previously supported Dart 3.6–3.12 or Flutter 3.24–3.47.6 versions, so they cannot resolve this package at the planned minor release. The platform interface needs a major version bump.

Release the platform interface as a major version and move every platform implementation with it in the same change.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: packages/simple_permissions_platform_interface/pubspec.yaml:14


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 5

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: 4f48e49060f537b947ade4a23646ac82df3352a6
  • Reviewed changes: the whole branch since fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The newly added meta dependency uses ^1.17.0 in the Android, iOS, and macOS manifests, and no lockfile is committed. CQS-DEP-02 requires exact dependency versions and a committed lockfile.

Required fix

Pin the new dependency exactly and commit the applicable lockfiles, or obtain a documented exception for published library packages.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new _extractReplyValueOrThrow function in all three generated Dart files lacks the Purpose comment and documentation block required by CQS-CLR-04.

Required fix

Update the generation process to supply the required purpose, parameter, return, and exception documentation for the new helper.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new _extractReplyValueOrThrow helper accepts three parameters, including a boolean, while retaining two positional arguments. This conflicts with CQS-CLR-10.

Required fix

Update the generation process so the helper receives its parameters through a named parameter object and update its callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new reply-extraction helper in each generated Dart file introduces a three-term condition combining !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02.

Required fix

Update the generation process to extract this condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-toolchain-architecture.md:115
  • Evidence: documentation
  • Canon document: reference/simple-zen-toolchain-architecture.md

Finding

The current PR title starts with chore(UNFY-409): rather than a bracketed issue identifier, violating TCA-BRN-04.

Required fix

Start the PR title with [UNFY-409].

Auto-merge (shadow): eligible; the human still merges.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: 4f48e49060f537b947ade4a23646ac82df3352a6
Comparison commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 5

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: 4f48e49060f537b947ade4a23646ac82df3352a6
  • Reviewed changes: the whole branch since fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The newly added meta dependency uses ^1.17.0 in the Android, iOS, and macOS manifests, and no lockfile is committed. CQS-DEP-02 requires exact dependency versions and a committed lockfile.

Required fix

Pin the new dependency exactly and commit the applicable lockfiles, or obtain a documented exception for published library packages.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new _extractReplyValueOrThrow function in all three generated Dart files lacks the Purpose comment and documentation block required by CQS-CLR-04.

Required fix

Update the generation process to supply the required purpose, parameter, return, and exception documentation for the new helper.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new _extractReplyValueOrThrow helper accepts three parameters, including a boolean, while retaining two positional arguments. This conflicts with CQS-CLR-10.

Required fix

Update the generation process so the helper receives its parameters through a named parameter object and update its callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The new reply-extraction helper in each generated Dart file introduces a three-term condition combining !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02.

Required fix

Update the generation process to extract this condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-toolchain-architecture.md:115
  • Evidence: documentation
  • Canon document: reference/simple-zen-toolchain-architecture.md

Finding

The current PR title starts with chore(UNFY-409): rather than a bracketed issue identifier, violating TCA-BRN-04.

Required fix

Start the PR title with [UNFY-409].

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

packages/simple_permissions_platform_interface/pubspec.yaml-13-14: 1

13-14: Major · Data Integrity & Integration · Heavy lift

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Use a major version for the platform-interface SDK break.

Consumers on the previously supported SDKs cannot select this version without upgrading their SDK. Pub can instead retain an older compatible package version. (dart.dev)

The planned minor release does not satisfy the repository rule. Coordinate a major interface version and the platform-package dependency constraints. As per coding guidelines, “A breaking change to simple_permissions_platform_interface is a major bump, and every platform implementation moves with it in the same change.”

Source: Coding guidelines

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 53625d4f-f823-4ce3-bce7-a6ee9f927d59
Commits

Reviewing files that changed from the base of the PR and between fa0a475 and 4f48e49.

Files ignored due to path filters: 3

  • packages/simple_permissions_android/lib/src/generated/permissions.g.dart is excluded by !**/generated/**
  • packages/simple_permissions_ios/lib/src/generated/permissions_ios.g.dart is excluded by !**/generated/**
  • packages/simple_permissions_macos/lib/src/generated/permissions_macos.g.dart is excluded by !**/generated/**
Files selected for processing: 26

  • CHANGELOG.md
  • analysis_options.yaml
  • docs/ENUMS_TO_SEALED.md
  • example/pubspec.yaml
  • packages/simple_permissions_android/CHANGELOG.md
  • packages/simple_permissions_android/analysis_options.yaml
  • packages/simple_permissions_android/android/src/main/kotlin/io/simplezen/simple_permissions_android/Permissions.g.kt
  • packages/simple_permissions_android/pigeon.dart
  • packages/simple_permissions_android/pubspec.yaml
  • packages/simple_permissions_ios/CHANGELOG.md
  • packages/simple_permissions_ios/analysis_options.yaml
  • packages/simple_permissions_ios/ios/simple_permissions_ios/Sources/simple_permissions_ios/PermissionsIos.g.swift
  • packages/simple_permissions_ios/pigeon.dart
  • packages/simple_permissions_ios/pubspec.yaml
  • packages/simple_permissions_macos/CHANGELOG.md
  • packages/simple_permissions_macos/analysis_options.yaml
  • packages/simple_permissions_macos/macos/simple_permissions_macos/Sources/simple_permissions_macos/PermissionsMacos.g.swift
  • packages/simple_permissions_macos/pigeon.dart
  • packages/simple_permissions_macos/pubspec.yaml
  • packages/simple_permissions_platform_interface/CHANGELOG.md
  • packages/simple_permissions_platform_interface/analysis_options.yaml
  • packages/simple_permissions_platform_interface/pubspec.yaml
  • packages/simple_permissions_web/CHANGELOG.md
  • packages/simple_permissions_web/analysis_options.yaml
  • packages/simple_permissions_web/pubspec.yaml
  • pubspec.yaml
Files with no reviewable changes: 6

  • analysis_options.yaml
  • packages/simple_permissions_android/analysis_options.yaml
  • packages/simple_permissions_ios/analysis_options.yaml
  • packages/simple_permissions_macos/analysis_options.yaml
  • packages/simple_permissions_platform_interface/analysis_options.yaml
  • packages/simple_permissions_web/analysis_options.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@jake-dev-99 jake-dev-99 changed the title chore(UNFY-409): upgrade flutter_lints and pigeon, raise the SDK floor [UNFY-409] Upgrade flutter_lints and pigeon, raise the SDK floor Nov 18, 2026
jake-dev-99 and others added 2 commits November 18, 2026 01:03
Flutter 3.50 deprecates package:flutter/material.dart and requires
Android Gradle Plugin 9.1.1. The example moves to material_ui, AGP 9.4.1
and Gradle 9.8.1. flutter_lints and pigeon are exact pins (CQS-DEP-02).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Review follow-up: the migration left material_ui after a stray blank line with none before dev_dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 6

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: 3c2db52769cff921d353693b3ee3a1b3f25e0f1c
  • Reviewed changes: commits since the completed review of 4f48e49060f537b947ade4a23646ac82df3352a6
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The Android, iOS, and macOS manifests still declare meta as ^1.17.0, and no lockfiles are committed. This violates CQS-DEP-02.

Required fix

Pin meta exactly and commit the applicable lockfiles, or document a ratified exception for these library packages.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The _extractReplyValueOrThrow helper in all three generated Dart files still lacks the Purpose comment and documentation block required by CQS-CLR-04.

Required fix

Update the generation process to supply the required purpose, parameter, return, and exception documentation.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The _extractReplyValueOrThrow helper retains two positional parameters despite taking three parameters, including a boolean, contrary to CQS-CLR-10.

Required fix

Update generation so all helper parameters are named, and update its callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Each generated reply-extraction helper still combines !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02.

Required fix

Update generation to extract the three-term condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:251
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The diff adds material_ui and replaces the example's Flutter Material import, but the supplied change description does not explain the new dependency. CQS-DEP-01 requires justification in the change description.

Required fix

Explain why material_ui is required and why the example is switching to it, or remove the dependency and import change.

6. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The example adds the pinned material_ui dependency without committing example/pubspec.lock. The new dependency therefore fails the lockfile requirement in CQS-DEP-02.

Required fix

Resolve the example dependencies and commit example/pubspec.lock.

Auto-merge (shadow): eligible; the human still merges.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: 3c2db52769cff921d353693b3ee3a1b3f25e0f1c
Comparison commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 6

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: 3c2db52769cff921d353693b3ee3a1b3f25e0f1c
  • Reviewed changes: commits since the completed review of 4f48e49060f537b947ade4a23646ac82df3352a6
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The Android, iOS, and macOS manifests still declare meta as ^1.17.0, and no lockfiles are committed. This violates CQS-DEP-02.

Required fix

Pin meta exactly and commit the applicable lockfiles, or document a ratified exception for these library packages.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The _extractReplyValueOrThrow helper in all three generated Dart files still lacks the Purpose comment and documentation block required by CQS-CLR-04.

Required fix

Update the generation process to supply the required purpose, parameter, return, and exception documentation.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The _extractReplyValueOrThrow helper retains two positional parameters despite taking three parameters, including a boolean, contrary to CQS-CLR-10.

Required fix

Update generation so all helper parameters are named, and update its callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Each generated reply-extraction helper still combines !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02.

Required fix

Update generation to extract the three-term condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:251
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The diff adds material_ui and replaces the example's Flutter Material import, but the supplied change description does not explain the new dependency. CQS-DEP-01 requires justification in the change description.

Required fix

Explain why material_ui is required and why the example is switching to it, or remove the dependency and import change.

6. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The example adds the pinned material_ui dependency without committing example/pubspec.lock. The new dependency therefore fails the lockfile requirement in CQS-DEP-02.

Required fix

Resolve the example dependencies and commit example/pubspec.lock.

Raising the floor to Flutter 3.47.7 / Dart 3.13 drops SDKs the current releases accept, so the next release is a major version (the next minor for 0.x packages). The Unreleased entries now say so, for whoever dispatches the release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jake-dev-99

Copy link
Copy Markdown
Owner Author

CodeRabbit's additional comment on packages/simple_permissions_platform_interface/pubspec.yaml (use a major version for the SDK break) is accepted, the same as the inline thread. The next release is 2.0.0, and every package's Unreleased changelog entry marks the floor raise as Breaking (f13751f).

@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 5

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: f13751f30b5d863c9ddcf3984afe6666792afd13
  • Reviewed changes: commits since the completed review of 3c2db52769cff921d353693b3ee3a1b3f25e0f1c
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Android, iOS, and macOS retain meta: ^1.17.0 without committed lockfiles. The recorded operator decision has not been processed through the ADR required by CQS-EXC-02, so the CQS-DEP-02 deviation remains unresolved.

Required fix

Record the approved library exception as the required Notion ADR, including its scope, reason, alternative, accepted risk, and resolution trigger; otherwise pin meta exactly and commit lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The three generated _extractReplyValueOrThrow helpers still lack the Purpose comment and documentation required by CQS-CLR-04. The PR acknowledges that the generated-code exemption has not yet been recorded as the required ADR.

Required fix

Record the approved generated-code exemption through CQS-EXC-02, or update generation to provide the required documentation.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The generated reply helpers retain positional parameters despite taking three parameters including a boolean, contrary to CQS-CLR-10. The stated exemption still lacks the ADR required by CQS-EXC-02.

Required fix

Record the approved generated-code exemption as the required ADR, or generate named parameters and update callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Each generated reply helper still combines !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02. The stated exemption has not completed the required ADR process.

Required fix

Record the approved generated-code exemption through CQS-EXC-02, or update generation to extract the condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The example declares material_ui: 1.11.1 without committing example/pubspec.lock, contrary to CQS-DEP-02. The proposed published-library exception does not cover this unpublished example application.

Required fix

Commit example/pubspec.lock, or obtain and record an exception explicitly covering the example.

Auto-merge (shadow): eligible; the human still merges.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: f13751f30b5d863c9ddcf3984afe6666792afd13
Comparison commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 5

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: fa0a4755e8e61d61079e4041a0f7b82cccf7780b
  • Reviewed commit: f13751f30b5d863c9ddcf3984afe6666792afd13
  • Reviewed changes: commits since the completed review of 3c2db52769cff921d353693b3ee3a1b3f25e0f1c
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Android, iOS, and macOS retain meta: ^1.17.0 without committed lockfiles. The recorded operator decision has not been processed through the ADR required by CQS-EXC-02, so the CQS-DEP-02 deviation remains unresolved.

Required fix

Record the approved library exception as the required Notion ADR, including its scope, reason, alternative, accepted risk, and resolution trigger; otherwise pin meta exactly and commit lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The three generated _extractReplyValueOrThrow helpers still lack the Purpose comment and documentation required by CQS-CLR-04. The PR acknowledges that the generated-code exemption has not yet been recorded as the required ADR.

Required fix

Record the approved generated-code exemption through CQS-EXC-02, or update generation to provide the required documentation.

3. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The generated reply helpers retain positional parameters despite taking three parameters including a boolean, contrary to CQS-CLR-10. The stated exemption still lacks the ADR required by CQS-EXC-02.

Required fix

Record the approved generated-code exemption as the required ADR, or generate named parameters and update callers.

4. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Each generated reply helper still combines !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02. The stated exemption has not completed the required ADR process.

Required fix

Record the approved generated-code exemption through CQS-EXC-02, or update generation to extract the condition into a named predicate.

5. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The example declares material_ui: 1.11.1 without committing example/pubspec.lock, contrary to CQS-DEP-02. The proposed published-library exception does not cover this unpublished example application.

Required fix

Commit example/pubspec.lock, or obtain and record an exception explicitly covering the example.

CQS-DEP-02 requires a committed lockfile. Stop ignoring pubspec.lock and
commit every package's and the example's lockfile, regenerated on Flutter
3.50 the way CI resolves them (the tracked pubspec_overrides.yaml links). pub leaves
pubspec.lock out of published archives, and Deploy's hosted pub get only
rewrites the runner's copy. AGENTS.md says when to commit lockfile changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

Review stopped after 3 complete reviews retained unresolved findings.

Operator direction is required before another review.

Outstanding unresolved findings

1. canon finding d96d8d88eb764fd1

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Finding: Android, iOS, and macOS retain meta: ^1.17.0 without committed lockfiles. The recorded operator decision has not been processed through the ADR required by CQS-EXC-02, so the CQS-DEP-02 deviation remains unresolved.
  • Required fix: Record the approved library exception as the required Notion ADR, including its scope, reason, alternative, accepted risk, and resolution trigger; otherwise pin meta exactly and commit lockfiles.

2. canon finding 24e5a85c521b45c1

  • Location: reference/simple-zen-code-quality-standard.md:133
  • Finding: The three generated _extractReplyValueOrThrow helpers still lack the Purpose comment and documentation required by CQS-CLR-04. The PR acknowledges that the generated-code exemption has not yet been recorded as the required ADR.
  • Required fix: Record the approved generated-code exemption through CQS-EXC-02, or update generation to provide the required documentation.

3. canon finding 6c5cd0768915d66f

  • Location: reference/simple-zen-code-quality-standard.md:129
  • Finding: The generated reply helpers retain positional parameters despite taking three parameters including a boolean, contrary to CQS-CLR-10. The stated exemption still lacks the ADR required by CQS-EXC-02.
  • Required fix: Record the approved generated-code exemption as the required ADR, or generate named parameters and update callers.

4. canon finding 173f9d01b796ca47

  • Location: reference/simple-zen-code-quality-standard.md:101
  • Finding: Each generated reply helper still combines !isNullValid, replyList.isNotEmpty, and replyList[0] == null without a named predicate, contrary to CQS-CLR-02. The stated exemption has not completed the required ADR process.
  • Required fix: Record the approved generated-code exemption through CQS-EXC-02, or update generation to extract the condition into a named predicate.

5. canon finding 1a5a23d8a107503c

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Finding: The example declares material_ui: 1.11.1 without committing example/pubspec.lock, contrary to CQS-DEP-02. The proposed published-library exception does not cover this unpublished example application.
  • Required fix: Commit example/pubspec.lock, or obtain and record an exception explicitly covering the example.

Diagnostic: review_cycle_cap_reached:cycle=4;cap=3;outstanding_findings=5

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@jake-dev-99
jake-dev-99 merged commit 0fcf92e into main Nov 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant