Skip to content

[UNFY-411] Upgrade flutter_lints and raise the SDK floor - #273

Merged
jake-dev-99 merged 6 commits into
mainfrom
chore/unfy-411-upgrade-lints-sdk-floor
Nov 18, 2026
Merged

jake-dev-99 merged 6 commits into
mainfrom
chore/unfy-411-upgrade-lints-sdk-floor

Conversation

@jake-dev-99

@jake-dev-99 jake-dev-99 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Part of UNFY-408 (dependency upgrade across Unify and the simple plugins). Closes UNFY-411.

What changed

  • flutter_lints 5 → 6 in the package and the example, pinned exactly (6.0.0). The dev dependency simple_query_platform_interface is pinned exactly too (0.2.2).
  • The package now requires Flutter 3.47.7 / Dart 3.13 (the Unify app's floor), up from Flutter 3.44 / Dart 3.12. It is listed under Breaking in the changelog: the next release is the next 0.x minor (0.8.0), which this package's other breaking entries already require.
  • flutter_lints 6 adds use_null_aware_elements. dart fix applied its six findings (if (x != null) 'k': x → 'k': ?x) in two lib/ files and two tests. Behaviour is unchanged.

Flutter 3.50

Stable moved to Flutter 3.50 while this PR was open, and CI runs on stable. 3.50 deprecates package:flutter/material.dart, so the example imports package:material_ui (1.11.1).

Merge order

CI checks out simple-permissions and simple-query at main. Merge jake-dev-99/simple-permissions#71 and jake-dev-99/simple-query#78 first. This branch was verified locally against those branches.

Verification (local, Flutter 3.50.0)

  • ./scripts/verify_mms_migration.sh: passed.
  • flutter analyze --no-fatal-warnings: no issues (package and example).
  • flutter test: 404 tests pass.
  • flutter pub publish --dry-run: 0 warnings.
  • Native gate: flutter build apk --debug in the example, then ./gradlew :simple_sms_native:testDebugUnitTest: BUILD SUCCESSFUL.
  • Lockfiles: regenerated from scratch, then analyze, tests and Pigeon regeneration re-run against them with no changes. No pubspec.lock in any published archive.
  • python3 -m unittest discover -s tool -p 'test_*.py': 158 tests OK, 4 skipped.

Not fixed here: example/test/widget_test.dart has no main and fails to load, the same as on main. Tracked in UNFY-416.

Reviews

Simple Zen canon review (sz-code-review, quick then full, at this head): PASS, no findings.

The first full review flagged the caret on simple_query_platform_interface, and it is now pinned exactly. I had wrongly told the reviewer that the release tooling needs ranges for it. The tooling only rewrites packages from this repo, and this package comes from simple-query.

Lockfiles (CQS-DEP-02): fixed. Every package's and the example's pubspec.lock is now committed, regenerated on Flutter 3.50 the way CI resolves it (through the tracked pubspec_overrides.yaml links and sibling checkouts). Trade-off: CI now tests the locked versions instead of the newest versions the constraints allow, so newer dependencies arrive through a committed flutter pub upgrade. pub leaves pubspec.lock out of published packages, and Deploy's pub get against hosted packages only rewrites the runner's copy. osv-scanner finds no advisories in the committed lockfiles. AGENTS.md now says when to commit lockfile changes.

One item is left to a canon amendment Jake is handling outside this PR (not a repo ADR): published libraries keep caret ranges for runtime dependencies. Dev dependencies are pinned exactly.

/code-review ran on every commit. Outcomes:

  • The environment comment explained only the old 3.44 floor → fixed.
  • material_ui sat under a stale "Cupertino Icons" comment → fixed.
  • The commented-out template test still imported flutter/material.dart → fixed.
  • The exact 0.2.2 interface pin can lag simple_query's own floor → kept, as the operator ruled (exact dev pins). The pin now carries a comment saying when to raise it. Dev dependencies never reach consumers.
  • material_ui is pinned exactly in an unpublished example → refuted. Examples are apps, and apps pin exactly.

Review conversations

  • Sourcery: AGENTS.md still documented Dart 3.12 / Flutter 3.44 → fixed (3fcbd7c). The raise itself is intended (UNFY-408).

🤖 Generated with Claude Code

Summary by Sourcery

Upgrade linting and example compatibility while raising the package SDK floor to match the Unify app.

Enhancements:

  • Raise the package and example minimum requirements to Dart 3.13 and Flutter 3.47.7.
  • Adopt the newer null-aware element lint guidance across production code and tests.
  • Update the example app for Flutter 3.50 compatibility using the material_ui package.

Build:

  • Upgrade flutter_lints to 6.0.0 and pin development dependencies to exact versions.

Documentation:

  • Document the raised SDK requirements as a breaking change for the next 0.x minor release.

Summary by CodeRabbit

  • Compatibility
    • Minimum requirements are now Dart 3.13 and Flutter 3.47.7. This is a breaking release and requires the next 0.x minor version.
  • Bug Fixes
    • Message IDs that cannot be parsed are omitted from change events, while valid IDs are retained.
    • Pending deletion requests consistently include thread and correlation ID fields, even when their values are null.
  • Chores
    • Updated example app dependencies and UI imports for compatibility with the newer Flutter and Dart versions.

Bump flutter_lints to 6 and raise the package to Flutter 3.47.7 /
Dart 3.13. Apply the null-aware element fixes the new lint set asks for.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Apply null-aware element syntax to message ID parsing and nullable method-channel arguments without changing behavior.

  • lib/src/android/models/messages/message_change_event.dart L97
  • lib/src/interop/channels.dart L146-147

UI

Switch the example app’s Flutter Material imports to material_ui for Flutter 3.50 compatibility.

  • example/lib/advanced_mms_example.dart L10
  • example/lib/background_example.dart L12
  • example/lib/conversation_example.dart L7
  • example/lib/main.dart L1
  • example/lib/simple_example.dart L7

Configuration

Raise the package and example SDK floors, upgrade and pin lint dependencies, pin the platform-interface dev dependency, and add material_ui to the example.

  • example/pubspec.yaml L8-9, L34, L47
  • pubspec.yaml L18-21, L47-55

Update ignore configuration to allow the newly committed lockfiles to be tracked.

  • .gitignore L20, L45 (removed lines)

Documentation

Document the new SDK floor, lockfile workflow, and breaking-release requirement.

  • AGENTS.md L54, L68-74
  • CHANGELOG.md L9

Tests

Adopt null-aware element syntax in test fixtures and update the commented example test import.

  • example/test/widget_test.dart L8
  • test/conversation_enrichment_test.dart L765
  • test/message_participant_test.dart L12-13

Lock files and vendored code

Commit the package and example dependency lockfiles resolved for the updated SDK and dependency constraints.

  • example/pubspec.lock L1-631
  • pubspec.lock L1-332

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T04:07:43.639177Z abd19d9 PR opened
🔒 Security Review ✅ Completed 2026-11-18T04:08:49.612513Z abd19d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes raise Dart and Flutter minimum versions, update dependency constraints and lockfile guidance, switch example UI imports to material_ui, and adjust nullable-value handling in message code and test fixtures.

Changes: SDK, example, and nullable-value updates

Layer / File(s) Summary
Package requirements and lockfile policy
pubspec.yaml, CHANGELOG.md, AGENTS.md, .gitignore
The package minimums change to Dart ^3.13.0 and Flutter >=3.47.7. Development dependency constraints and lockfile guidance change. .gitignore allows pubspec.lock to be tracked.
Example dependencies and UI imports
example/pubspec.yaml, example/lib/*, example/test/widget_test.dart
The example updates its SDK constraints, adds material_ui, and updates flutter_lints. Example Material imports change to material_ui imports, including the commented widget-test import.
Nullable-value handling and fixtures
lib/src/android/models/messages/message_change_event.dart, lib/src/interop/channels.dart, test/message_participant_test.dart, test/conversation_enrichment_test.dart
Message ID parsing excludes unparseable IDs. The pending send deletions call includes both argument keys when their values are null. Test helpers supply nullable address values and seed a null lookup row when no contact is supplied.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: Minimal · up to 124bd

This PR raises SDK minimums, pins lint and interface dependencies, and applies behavior-preserving lint fixes. No concrete merge-blocking risk was found; the minimum-version increase is documented as a breaking change in the changelog.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two changes that appear in the changeset: upgrading flutter_lints (pubspec.yaml and example/pubspec.yaml move it to exactly 6.0.0) and raising the SDK floor (pubspec.yaml and example/p…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two changes that appear in the changeset: upgrading flutter_lints (pubspec.yaml and example/pubspec.yaml move it to exactly 6.0.0) and raising the SDK floor (pubspec.yaml and example/pubspec.yaml move Dart to ^3.13.0 and Flutter to >=3.47.7). It omits other notable changes, such as the material_ui import swap, the null-aware lint fixes, the channel and test helper changes, and the lockfile policy change. That is expected for a short title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dce926ce-6a46-4000-bbe4-612928885f85
Commits

Reviewing files that changed from the base of the PR and between 62fd907 and 124bd1f.

Files ignored due to path filters: 2

  • example/pubspec.lock is excluded by !**/*.lock
  • pubspec.lock is excluded by !**/*.lock
Files selected for processing: 2

  • .gitignore
  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="pubspec.yaml" line_range="19" />
<code_context>
 environment:
-  sdk: ^3.12.0
-  flutter: ">=3.47.0"
+  sdk: ^3.13.0
+  flutter: ">=3.47.7"

</code_context>
<issue_to_address>
**Documented SDKs cannot resolve package**

When contributors follow the SDK versions in AGENTS.md or consumers use Dart 3.12 or Flutter 3.44, pub rejects the raised Dart and Flutter constraints during dependency resolution, so contributors cannot complete setup or run checks and consumers cannot resolve the package or example at the documented minimum versions.

Restore the Dart `^3.12.0` and Flutter `>=3.44.0` constraints in `pubspec.yaml`.

Also at `example/pubspec.yaml:8-9`, `pubspec.yaml:20`.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: pubspec.yaml:19


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread pubspec.yaml Resolved
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 3

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: abd19d93db7ed1a589ff40ad60d6a0f585ab631f
  • Reviewed changes: the whole branch since 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The updated flutter_lints dependencies in both manifests use ^6.0.0, and neither package has a committed lockfile. This violates CQS-DEP-02 and leaves the upgraded lint baseline unpinned.

Required fix

Pin flutter_lints to an exact version in both manifests and commit the corresponding lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-documentation-standard.md:332
  • Evidence: documentation
  • Canon document: reference/simple-zen-documentation-standard.md

Finding

The SDK floor changes to Dart 3.13 and Flutter 3.47.7, but AGENTS.md line 54 still documents Dart ^3.12.0 and Flutter >=3.44.0. This introduces documentation drift contrary to DOC-RPO-06.

Required fix

Update the SDK requirements in AGENTS.md to match both changed manifests.

3. Canon blocker

  • Location: reference/simple-zen-toolchain-architecture.md:115
  • Evidence: documentation
  • Canon document: reference/simple-zen-toolchain-architecture.md

Finding

The current PR title starts with chore(UNFY-411), whereas TCA-BRN-04 requires the Linear identifier in brackets at the start.

Required fix

Rename the PR to start with [UNFY-411], followed by the change description.

Auto-merge (shadow): eligible; the human still merges.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: abd19d93db7ed1a589ff40ad60d6a0f585ab631f
Comparison commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 3

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: abd19d93db7ed1a589ff40ad60d6a0f585ab631f
  • Reviewed changes: the whole branch since 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The updated flutter_lints dependencies in both manifests use ^6.0.0, and neither package has a committed lockfile. This violates CQS-DEP-02 and leaves the upgraded lint baseline unpinned.

Required fix

Pin flutter_lints to an exact version in both manifests and commit the corresponding lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-documentation-standard.md:332
  • Evidence: documentation
  • Canon document: reference/simple-zen-documentation-standard.md

Finding

The SDK floor changes to Dart 3.13 and Flutter 3.47.7, but AGENTS.md line 54 still documents Dart ^3.12.0 and Flutter >=3.44.0. This introduces documentation drift contrary to DOC-RPO-06.

Required fix

Update the SDK requirements in AGENTS.md to match both changed manifests.

3. Canon blocker

  • Location: reference/simple-zen-toolchain-architecture.md:115
  • Evidence: documentation
  • Canon document: reference/simple-zen-toolchain-architecture.md

Finding

The current PR title starts with chore(UNFY-411), whereas TCA-BRN-04 requires the Linear identifier in brackets at the start.

Required fix

Rename the PR to start with [UNFY-411], followed by the change description.

@jake-dev-99 jake-dev-99 changed the title chore(UNFY-411): upgrade flutter_lints and raise the SDK floor [UNFY-411] Upgrade flutter_lints and raise the SDK floor Nov 18, 2026
jake-dev-99 and others added 3 commits November 18, 2026 01:03
Flutter 3.50 deprecates package:flutter/material.dart; the example moves
to material_ui. AGENTS.md states the new SDK floor.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Every dev dependency is pinned exactly. simple_query_platform_interface
comes from simple-query, so this repo's release tooling does not rewrite
it as an internal package, and the caret range is not needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review follow-up. The environment comment explained only the old 3.44 floor, the interface dev pin now says when to raise it, material_ui no longer sits under a stale Cupertino Icons comment, and the commented-out template test imports material_ui.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 2

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: 9b2327ead3ca0a6738d42a17666cfcef0ecc00a2
  • Reviewed changes: commits since the completed review of abd19d93db7ed1a589ff40ad60d6a0f585ab631f
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Both manifests now pin flutter_lints to 6.0.0, but neither pubspec.lock nor example/pubspec.lock is committed. CQS-DEP-02 requires committed lockfiles as well as exact versions.

Required fix

Generate and commit the root and example lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:251
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The diff adds material_ui 1.11.1 and migrates five example imports to it, but the supplied PR description does not mention or justify this new dependency, violating CQS-DEP-01.

Required fix

Explain the material_ui dependency and import migration in the PR description, including why it is required.

Auto-merge (shadow): held for human review — gate/canon.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: 9b2327ead3ca0a6738d42a17666cfcef0ecc00a2
Comparison commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 2

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: 9b2327ead3ca0a6738d42a17666cfcef0ecc00a2
  • Reviewed changes: commits since the completed review of abd19d93db7ed1a589ff40ad60d6a0f585ab631f
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Both manifests now pin flutter_lints to 6.0.0, but neither pubspec.lock nor example/pubspec.lock is committed. CQS-DEP-02 requires committed lockfiles as well as exact versions.

Required fix

Generate and commit the root and example lockfiles.

2. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:251
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

The diff adds material_ui 1.11.1 and migrates five example imports to it, but the supplied PR description does not mention or justify this new dependency, violating CQS-DEP-01.

Required fix

Explain the material_ui dependency and import migration in the PR description, including why it is required.

Raising the floor to Flutter 3.47.7 / Dart 3.13 drops SDKs the current releases accept, so the next release is a major version (the next minor for 0.x packages). The Unreleased entries now say so, for whoever dispatches the release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

SZ Code Review

Verdict: FAIL
Findings: 1

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: 62fd9079010adff018b7103690d1bbdd97ae864a
  • Reviewed changes: commits since the completed review of 9b2327ead3ca0a6738d42a17666cfcef0ecc00a2
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Root and example lockfiles remain uncommitted, contrary to CQS-DEP-02. The PR's claimed published-library exception has no completed ADR and does not establish an exception for the unpublished example app.

Required fix

Commit both lockfiles, or obtain explicit operator approval and complete the required exception ADR covering each omitted lockfile.

Auto-merge (shadow): held for human review — gate/canon.

@sz-overseer-jake-dev-99 sz-overseer-jake-dev-99 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head: 62fd9079010adff018b7103690d1bbdd97ae864a
Comparison commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
Revision: 1

SZ Code Review

Verdict: FAIL
Findings: 1

Review boundary

  • Mode: full
  • Scope: all
  • Lifecycle: commit
  • Base commit: 1887a279a93862353a7045b2a7dbc5d7c28b53cf
  • Reviewed commit: 62fd9079010adff018b7103690d1bbdd97ae864a
  • Reviewed changes: commits since the completed review of 9b2327ead3ca0a6738d42a17666cfcef0ecc00a2
  • Revision: 1
  • Review cycle: 1 of 3
  • Pre-push authoritative: yes

Findings

1. Canon blocker

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Evidence: documentation
  • Canon document: reference/simple-zen-code-quality-standard.md

Finding

Root and example lockfiles remain uncommitted, contrary to CQS-DEP-02. The PR's claimed published-library exception has no completed ADR and does not establish an exception for the unpublished example app.

Required fix

Commit both lockfiles, or obtain explicit operator approval and complete the required exception ADR covering each omitted lockfile.

CQS-DEP-02 requires a committed lockfile. Stop ignoring pubspec.lock and
commit every package's and the example's lockfile, regenerated on Flutter
3.50 the way CI resolves them (the tracked pubspec_overrides.yaml links). pub leaves
pubspec.lock out of published archives, and Deploy's hosted pub get only
rewrites the runner's copy. AGENTS.md says when to commit lockfile changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sz-overseer-jake-dev-99

Copy link
Copy Markdown

Review stopped after 3 complete reviews retained unresolved findings.

Operator direction is required before another review.

Outstanding unresolved findings

1. canon finding e567c8cd496d243c

  • Location: reference/simple-zen-code-quality-standard.md:255
  • Finding: Root and example lockfiles remain uncommitted, contrary to CQS-DEP-02. The PR's claimed published-library exception has no completed ADR and does not establish an exception for the unpublished example app.
  • Required fix: Commit both lockfiles, or obtain explicit operator approval and complete the required exception ADR covering each omitted lockfile.

Diagnostic: review_cycle_cap_reached:cycle=4;cap=3;outstanding_findings=1

@jake-dev-99
jake-dev-99 merged commit 624ab60 into main Nov 18, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant