Skip to content

Update default Cartpole camera resolution#6632

Merged
kellyguo11 merged 7 commits into
isaac-sim:developfrom
kellyguo11:kelly/update-cartpole-camera-resolution
Jul 21, 2026
Merged

Update default Cartpole camera resolution#6632
kellyguo11 merged 7 commits into
isaac-sim:developfrom
kellyguo11:kelly/update-cartpole-camera-resolution

Conversation

@kellyguo11

@kellyguo11 kellyguo11 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

  • Change the direct and manager-based Cartpole camera defaults from 100x100 to 96x96.
  • Remove the explicit Newton 10x10 tiled-rendering override so Cartpole uses the renderer default of 8x8.
  • Keep rendering test observation shapes, visualizer test documentation, and Hydra documentation aligned with the new default.
  • Regenerate all 77 affected Cartpole golden images at the resulting 198x198 comparison-grid resolution.
  • Increase the Cartpole pixel-difference tolerance from 1.0% to 1.5% for cross-GPU RTX anti-aliasing variation while retaining SSIM validation.

This makes the default camera dimensions evenly divisible by Newton's default tile size. Users who need the previous behavior can explicitly configure a 100x100 camera and 10x10 Newton tiles.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Validation

  • ./isaaclab.sh -p tools/changelog/cli.py check develop
  • ./isaaclab.sh -f
  • ./isaaclab.sh -d
  • CI comparison artifact: 1.16% pixel difference accepted with SSIM 0.9992
  • test_rendering_cartpole.py: 30 passed, 1 skipped
  • test_rendering_cartpole_kitless.py: 33 passed, 1 skipped
  • Cartpole cases in test_rendering_registered_tasks.py: 7 passed
  • Python byte-compilation of the four modified Python files

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh -f
  • Hydra and test documentation were updated where they referenced the old default
  • My changes generate no new warnings
  • Existing rendering-test configurations and golden images were updated for the new image shape
  • I have added a changelog fragment for every touched package
  • My name already exists in CONTRIBUTORS.md

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Jul 20, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 20, 2026
@kellyguo11
kellyguo11 marked this pull request as ready for review July 20, 2026 20:16
@kellyguo11
kellyguo11 requested a review from a team July 20, 2026 20:16
@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the default Cartpole tiled camera resolution from 100×100 to 96×96 in both the direct and manager-based camera environment configs, and removes the explicit Newton tile_rendering_width=10, tile_rendering_height=10 override so the Newton renderer falls back to its built-in 8×8 default. The motivation is that 96 divides evenly by 8, avoiding a tile-alignment mismatch that existed with the previous 100×100 / 10×10 pairing.

  • Camera width/height changed from 100 to 96 in both cartpole_direct_camera_env_cfg.py and cartpole_manager_camera_env_cfg.py; renderer_cfg simplified to MultiBackendRendererCfg(newton_renderer=NewtonWarpRendererCfg()).
  • All dependent observation_space declarations, test configs, Hydra docs (including emphasize-lines), and 77 golden PNG comparison images updated to match the new 96×96 / 198×198 grid resolution.

Confidence Score: 5/5

Safe to merge — the change is a straightforward default value update with consistent follow-through across all dependent configs, tests, docs, and golden images.

The resolution change from 100×100 to 96×96 is mechanically simple and is applied uniformly: both camera env configs, all observation_space declarations, all test configs, the Hydra docs (including the emphasize-lines which now correctly land on width and observation_space given the shorter renderer_cfg), and all 77 golden images are updated.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_tasks/isaaclab_tasks/core/cartpole/cartpole_direct_camera_env_cfg.py Camera width/height changed 100→96, Newton tile override removed; observation_space updated consistently for rgb/depth/semantic variants.
source/isaaclab_tasks/isaaclab_tasks/core/cartpole/cartpole_manager_camera_env_cfg.py Same camera resolution and renderer config change as the direct variant; no manager-side observation_space declared, so no secondary updates needed.
source/isaaclab_tasks/test/rendering_test_utils.py All seven observation_space overrides updated from [C, 100, 100] to [C, 96, 96] to match the new camera default.
docs/source/features/hydra.rst end-at anchor, example shapes, and Hydra command-line example updated from 100 to 96; emphasize-lines 12,43 now correctly highlight width and observation_space given the shorter single-line renderer_cfg.
source/isaaclab_visualizers/test/visualizer_integration_utils.py Comment strings updated to reference 96×96 preset default; actual resolution constants (400×400 override) are unchanged.
source/isaaclab_tasks/changelog.d/kelly-update-cartpole-camera-resolution.rst New changelog fragment accurately describes the resolution change and Newton tile-size behavior for users.

Reviews (1): Last reviewed commit: "Fix Cartpole camera docs include" | Re-trigger Greptile

@kellyguo11
kellyguo11 merged commit a8a14ca into isaac-sim:develop Jul 21, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants