Skip to content

Bump h5py version to >=3.16.0#6266

Open
peterd-NV wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
peterd-NV:peterd/bump-h5py
Open

Bump h5py version to >=3.16.0#6266
peterd-NV wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
peterd-NV:peterd/bump-h5py

Conversation

@peterd-NV

@peterd-NV peterd-NV commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Bumps h5py dep version to >=3.16.0 to be in line with Isaac Sim 6.0 GA which requires 3.16.x

Fixes #6213

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the isaac-mimic Related to Isaac Mimic team label Jun 25, 2026
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the h5py dependency from the pinned ==3.15.1 to >=3.16.0 in both the isaaclab_mimic and isaaclab_rl packages, aligning with the Isaac Sim 6.0 GA requirement for h5py 3.16.x. Changelog fragment files are added for both packages.

  • source/isaaclab_mimic/setup.py and source/isaaclab_rl/setup.py: h5py version constraint relaxed from a strict pin to a minimum version bound.
  • Changelog entries: Two new changelog.d/ fragments document the change for both packages.

Confidence Score: 5/5

This PR is safe to merge — it is a minimal, targeted dependency constraint change with no logic modifications.

Both setup.py files change a single version pin for h5py to a minimum-version bound, and the changelog fragments accurately describe the change. No other files are touched, and the update aligns with the stated Isaac Sim 6.0 GA requirement.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_mimic/setup.py Bumps h5py from ==3.15.1 to >=3.16.0; straightforward version constraint change with no other modifications.
source/isaaclab_rl/setup.py Bumps h5py from ==3.15.1 to >=3.16.0; mirrors the same change in isaaclab_mimic/setup.py.
source/isaaclab_mimic/changelog.d/peterd-bump-h5py.rst New changelog fragment accurately describing the h5py version bump.
source/isaaclab_rl/changelog.d/peterd-bump-h5py.rst New changelog fragment accurately describing the h5py version bump.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Isaac Sim 6.0 GA] -->|requires| B[h5py 3.16.x]
    C[isaaclab_mimic/setup.py] -->|before: h5py==3.15.1| D[❌ Incompatible]
    C -->|after: h5py>=3.16.0| E[✅ Compatible]
    F[isaaclab_rl/setup.py] -->|before: h5py==3.15.1| D
    F -->|after: h5py>=3.16.0| E
    B --> E
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Isaac Sim 6.0 GA] -->|requires| B[h5py 3.16.x]
    C[isaaclab_mimic/setup.py] -->|before: h5py==3.15.1| D[❌ Incompatible]
    C -->|after: h5py>=3.16.0| E[✅ Compatible]
    F[isaaclab_rl/setup.py] -->|before: h5py==3.15.1| D
    F -->|after: h5py>=3.16.0| E
    B --> E
Loading

Reviews (1): Last reviewed commit: "bump h5py version" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-mimic Related to Isaac Mimic team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant