Bump h5py version to >=3.16.0#6266
Open
peterd-NV wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR bumps the
Confidence Score: 5/5This PR is safe to merge — it is a minimal, targeted dependency constraint change with no logic modifications. Both setup.py files change a single version pin for h5py to a minimum-version bound, and the changelog fragments accurately describe the change. No other files are touched, and the update aligns with the stated Isaac Sim 6.0 GA requirement. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Isaac Sim 6.0 GA] -->|requires| B[h5py 3.16.x]
C[isaaclab_mimic/setup.py] -->|before: h5py==3.15.1| D[❌ Incompatible]
C -->|after: h5py>=3.16.0| E[✅ Compatible]
F[isaaclab_rl/setup.py] -->|before: h5py==3.15.1| D
F -->|after: h5py>=3.16.0| E
B --> E
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Isaac Sim 6.0 GA] -->|requires| B[h5py 3.16.x]
C[isaaclab_mimic/setup.py] -->|before: h5py==3.15.1| D[❌ Incompatible]
C -->|after: h5py>=3.16.0| E[✅ Compatible]
F[isaaclab_rl/setup.py] -->|before: h5py==3.15.1| D
F -->|after: h5py>=3.16.0| E
B --> E
Reviews (1): Last reviewed commit: "bump h5py version" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps h5py dep version to >=3.16.0 to be in line with Isaac Sim 6.0 GA which requires 3.16.x
Fixes #6213
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there