Revert "Add per-env omni:scenePartition authoring in InteractiveScene…#6170
Revert "Add per-env omni:scenePartition authoring in InteractiveScene…#6170mataylor-nvidia wants to merge 3 commits into
Conversation
Greptile SummaryThis PR reverts commit
Confidence Score: 5/5Clean revert of a well-scoped feature; restores last known working behavior with no new logic introduced. Every changed file is a straightforward removal of the feature being reverted. Imports are correctly cleaned up — No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[InteractiveScene / sim.reset] --> B[prepare_stage called]
B -->|Before revert| C["Author primvars:omni:scenePartition\non each /World/envs/env_N root\n(Sdf.ChangeBlock loop)"]
B -->|After revert| D["pass — no-op"]
C --> E["renderer.scenePartitioning.enabled = true\nin all .kit configs"]
D --> F["renderer.scenePartitioning.enabled\nremoved from all .kit configs"]
C --> G["_apply_viewport_camera_scene_partition\ntags Kit viewport camera"]
D --> H["Method removed from KitVisualizer"]
C --> I["create_visualizer_camera sets\nomni:scenePartition on spawned cameras"]
D --> J["Attribute authoring block\nremoved from camera_view.py"]
E -->|OOM at >2048 envs| K["GPU ERROR_OUT_OF_DEVICE_MEMORY"]
F --> L["Restored working behavior"]
Reviews (1): Last reviewed commit: "Add my name to contributors" | Re-trigger Greptile |
… (#5445)"
This reverts commit e0ccad6.
Description
This PR reverts commit e0ccad6, which added per-env
omni:scenePartitionauthoring for RTX cull-by-env rendering.The change is being reverted because it causes GPU out-of-memory failures when running with more than
2048 environments. The issue was reproduced with Isaac Sim versions up to
6.0.1-rc.4+release.42160.3ae239b5.gl.manylinux_2_35_x86_64.release.The regression appears specifically related to creating attributes with the
primvars:prefix. Until theupstream RTX/Isaac Sim issue is resolved, reverting this change restores the last known working behavior.
Primary observed errors:
Expected behavior:
There should not be any GPU out-of-memory error when rendering environments above this scale.
Last known working details:
developType of change
Screenshots
N/A. This revert addresses GPU memory failures during RTX rendering rather than a visible UI change.
Checklist
pre-commitchecks with./isaaclab.sh -fCONTRIBUTORS.mdor my name already exists there