Skip to content

Revert "Add per-env omni:scenePartition authoring in InteractiveScene…#6170

Open
mataylor-nvidia wants to merge 3 commits into
isaac-sim:developfrom
mataylor-nvidia:mandre-taylor/revert-scene-partitioning
Open

Revert "Add per-env omni:scenePartition authoring in InteractiveScene…#6170
mataylor-nvidia wants to merge 3 commits into
isaac-sim:developfrom
mataylor-nvidia:mandre-taylor/revert-scene-partitioning

Conversation

@mataylor-nvidia

Copy link
Copy Markdown

… (#5445)"

This reverts commit e0ccad6.

Description

This PR reverts commit e0ccad6, which added per-env
omni:scenePartition authoring for RTX cull-by-env rendering.

The change is being reverted because it causes GPU out-of-memory failures when running with more than
2048 environments. The issue was reproduced with Isaac Sim versions up to
6.0.1-rc.4+release.42160.3ae239b5.gl.manylinux_2_35_x86_64.release.

The regression appears specifically related to creating attributes with the primvars: prefix. Until the
upstream RTX/Isaac Sim issue is resolved, reverting this change restores the last known working behavior.

Primary observed errors:

[omni.rtx] VkResult: ERROR_OUT_OF_DEVICE_MEMORY
[omni.rtx] vkAllocateMemory failed for flags: 0.
[rtx.scenedb] Mesh "/__Prototype_2108403017326860070_Instancer/proto13594164051239155749/Gprim": Failed to initialize index buffer from cache key
[rtx.scenedb.plugin] Failed to create PreprocessedAnimatedMesh: Out of memory
[omni.rtx] Out of GPU memory allocating resource 'MemoryManager chunk' [size: unknown]

Expected behavior:

There should not be any GPU out-of-memory error when rendering environments above this scale.

Last known working details:

  • Isaac Sim: 6.0
  • Isaac Lab: develop

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A. This revert addresses GPU memory failures during RTX rendering rather than a visible UI change.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh -f
  • I have made corresponding changes to the documentation, or no documentation changes are required
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or existing regression coverage is not applicable for this revert
  • I have updated the changelog and version metadata, or no changelog/version update is required for this revert
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added isaac-sim Related to Isaac Sim team isaac-lab Related to Isaac Lab team labels Jun 12, 2026
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reverts commit e0ccad65, which introduced per-env omni:scenePartition USD attribute authoring for RTX cull-by-env rendering. The revert is motivated by a confirmed GPU out-of-memory regression at >2048 environments, traced to creating attributes with the primvars: prefix in that version of Isaac Sim.

  • Removes renderer.scenePartitioning.enabled = true from all six .kit app config files, and strips the matching primvars:omni:scenePartition/omni:scenePartition authoring code from isaac_rtx_renderer.py, camera_view.py, and kit_visualizer.py.
  • Deletes the test_isaac_rtx_renderer_scene_partitioning.py regression test suite and updates golden rendering images to match the pre-partitioning output.

Confidence Score: 5/5

Clean revert of a well-scoped feature; restores last known working behavior with no new logic introduced.

Every changed file is a straightforward removal of the feature being reverted. Imports are correctly cleaned up — Sdf in isaac_rtx_renderer.py is legitimately retained for the Isaac Sim 4.5 instancing workaround at line 229. The prepare_stage no-op and the deleted test file are both consistent with the intent. Golden images are updated to match the pre-feature rendering output. No dangling references or partial reverts were found.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_physx/isaaclab_physx/renderers/isaac_rtx_renderer.py Replaces the per-env primvars:omni:scenePartition authoring logic in prepare_stage with a no-op pass; removes now-unneeded Usd and UsdGeom top-level imports while correctly retaining Sdf which is still used by the Isaac Sim 4.5 instancing workaround.
source/isaaclab/isaaclab/envs/utils/camera_view.py Removes the post-spawn block that created and set omni:scenePartition on each visualizer camera prim; cleans up the now-unused Sdf import.
source/isaaclab_visualizers/isaaclab_visualizers/kit/kit_visualizer.py Removes the _apply_viewport_camera_scene_partition helper and its call site; drops the now-unused Sdf import from the pxr import line.
source/isaaclab_physx/test/renderers/test_isaac_rtx_renderer_scene_partitioning.py Entire file deleted — removes the regression tests that validated per-env tile isolation, consistent with reverting the feature they covered.
apps/isaaclab.python.kit Removes renderer.scenePartitioning.enabled = true; representative of the same one-line deletion across all six .kit app files.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[InteractiveScene / sim.reset] --> B[prepare_stage called]
    B -->|Before revert| C["Author primvars:omni:scenePartition\non each /World/envs/env_N root\n(Sdf.ChangeBlock loop)"]
    B -->|After revert| D["pass — no-op"]
    C --> E["renderer.scenePartitioning.enabled = true\nin all .kit configs"]
    D --> F["renderer.scenePartitioning.enabled\nremoved from all .kit configs"]
    C --> G["_apply_viewport_camera_scene_partition\ntags Kit viewport camera"]
    D --> H["Method removed from KitVisualizer"]
    C --> I["create_visualizer_camera sets\nomni:scenePartition on spawned cameras"]
    D --> J["Attribute authoring block\nremoved from camera_view.py"]
    E -->|OOM at >2048 envs| K["GPU ERROR_OUT_OF_DEVICE_MEMORY"]
    F --> L["Restored working behavior"]
Loading

Reviews (1): Last reviewed commit: "Add my name to contributors" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant