Avoid per-step state allocations in static revolute and wheel joints - #102
Open
edwardgushchin wants to merge 2 commits into
Open
edwardgushchin wants to merge 2 commits into
edwardgushchin wants to merge 2 commits into
Conversation
edwardgushchin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a static and dynamic body connected by a revolute or wheel joint, warm-start and solve each clone the static identity body state even though those branches only read it. In a four-substep downstream fixed step, either active joint allocated 576 managed bytes per frame.
Reuse the existing identity state in those four branches. Dynamic-body writes remain guarded by the dynamic flag. Downstream warmed revolute and wheel joint tests now measure zero managed bytes over 64 active frames each.
Validation:
dotnet test test/Box2D.NET.Test/Box2D.NET.Test.csproj -c Release -f net10.0 --no-restore(199 passed). An earlier complete multi-target run passed 199 tests on net8.0 and net10.0 but could not run net9.0 because that runtime is not installed locally.