Skip to content

fix(ci): restore quality gate after UI integration - #1

Closed
hvab wants to merge 4 commits into
mainfrom
fix/remote-quality-checks
Closed

hvab wants to merge 4 commits into
mainfrom
fix/remote-quality-checks

Conversation

@hvab

@hvab hvab commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

The current main (8662ce5a7a94fff4df4f95bab34a0f48eea9b561) fails the quality gate after its UI integration: the saved-session fixture still uses the removed system appearance, PresetSelector is not formatted, App.css has seven stylelint errors, and tracked audit Markdown is not formatted.

Restore the gate without changing product behavior or quality rules:

  • Align session fixtures with the existing light/dark policy; add explicit legacy system/missing rejection regressions and keep unsupported-version validation isolated. Runtime storage is unchanged.
  • Format PresetSelector's opening tag without changing attributes.
  • Move the global root/popper layer rules from scoped App.css to an unscoped shell stylesheet. A Vue compilation regression verifies identical selectors, declarations and priority; the import order stays after library styles. Consolidate/reorder the duplicate error rule and replace deprecated clipping for the hidden status.
  • Format the existing prompts and already published tracked reports. Report formatting is a separate commit; normalized Markdown and embedded JavaScript ASTs match main, preserving text, data, links and semantic structure. No new reports are added.

Validation: 104/104 tests, JS lint, style lint, formatting and build pass locally on Node 24/macOS. Invalid ordinary CSS pseudo-classes still fail stylelint. Chrome light/dark Share/Reset layers are 10/20; copy status keeps its role and 1px clipped box; metadata errors still disable ZIP with the same header error layout.

Local npm ci is blocked by EALLOWGIT for the existing pinned Git dependency; no bypass was attempted. Local checks use a copy of the installed dependencies with a byte-identical lockfile. PR CI supplies the clean Node 22/Linux install verification. Full npm audit was inspected read-only (16 flagged package records); dependencies, lockfile and lint/format policies remain unchanged. Browser impact from the advisories is not demonstrated. Dependency remediation is separate.

Updated from main by merge, without force push, main mutation, PR merge/closure, or changes to the new App.vue behavior or panel widths. Plain-font parity remains in #4.

@hvab hvab changed the title fix(ci): format tracked audit prompts fix(ci): restore quality gate after UI integration Oct 3, 2026
@hvab hvab closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant