Repository navigation
Add cumulative profitability charts (chips + dollars) - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two cumulative "winnings graph" charts to the dashboard (PokerTracker/HM style):
hero_prize − buy_in) over tournaments.Real-money P&L resolves per tournament. The parser already extracts hero's prize from summary
finishes; this persists it in a new
tournaments.hero_prizecolumn (the table previously had nocolumn for it) and derives the dollar timeline from it.
Changes
0003_tournament_hero_prize.sql;hero_prizethreaded throughTABLE_COLUMNS, parsermapping, and the
Tournamentmodel (computed fromfinishes[].prizewhere name == "Hero").overview()gainschips_timeline/dollars_timeline(running cumulative, downsampled to<=1500 points); new
TimelinePointmodel.CumulativeResultarea chart,formatUsd, two dashboard cards.Verification
uv run pytest(36 passed),ruff+mypyclean; frontendtypecheck+lintclean.hero_prize), verified the $ timelineresolves to a real net (+$180.84) instead of
-sum(buy_in).