Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dashboard breakdowns of hero results by position (UTG/HJ/CO/BTN/SB/BB) and by effective
stack — to surface where in a tournament the user earns most/least — in two units:
replaced by
equity * pot - invested, stripping variance.Changes
crates/hh-parser/src/equity.rs): self-contained 7-card evaluator +seeded SplitMix64 Monte-Carlo (preflop) / exhaustive enumeration (flop+). Deterministic, no new
deps. Parser sets
chip_evper player (=resultoutside qualifying all-in showdowns).0004_chip_ev.sql;chip_evthreaded through mapping (both paths),HandPlayer,TABLE_COLUMNS, and exposed via PyO3.overview()gainsby_positionandresult_evon each bucket; newPositionBucketmodel.MetricByCategorygrouped-bar chart (chips/100 vs chipEV/100, totals/hands/winrate tooltip);two dashboard cards (by position, by effective stack).
v1 limitation
chipEV adjusts only 2-player all-in showdowns with both hole cards known. Multiway/side-pot
all-ins and unknown cards keep the actual result.
Verification
cargo test(16 passed: AA vs KK ~82%, zero-sum, uncalled all-in == result).uv run pytest(38 passed),ruff+mypyclean; frontendtypecheck+lintclean.OPTIMIZE FINAL, no dup inflation).Result: BTN best (+1,645 chips/100), BB worst (-737/100); hero +806,500 chips vs +760,657 chipEV.