Support for DPKG (Debian) parser#168
Merged
Merged
Conversation
|
Just want to chime in this would be very useful |
G-Rath
approved these changes
Feb 2, 2023
G-Rath
left a comment
G-Rath
left a comment
Collaborator
There was a problem hiding this comment.
looks good! just got one comment about a doc comment :)
…anning Co-authored-by: Gareth Jones <Jones258@Gmail.com>
oliverchang
reviewed
Feb 8, 2023
oliverchang
left a comment
oliverchang
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution! Apologies for the delay in reviewing this.
oliverchang
reviewed
Feb 8, 2023
Contributor
Author
|
I also realized that my current parser version is "too aggressive" and can lead to potential false positives. |
cmaritan
force-pushed
the
dpkg-status
branch
from
c88ec52 to
e4dd1c0
Compare
Contributor
Author
|
Hello @oliverchang , now my PR:
|
another-rex
approved these changes
Feb 17, 2023
another-rex
left a comment
another-rex
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just some minor nits.
Contributor
Author
|
Thank you @another-rex , committed suggested changes. |
another-rex
approved these changes
Feb 20, 2023
oliverchang
pushed a commit
that referenced
this pull request
Feb 20, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in #168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in #149. Thank you, Regards.
hayleycd
pushed a commit
that referenced
this pull request
Mar 9, 2023
As discussed in #164 [here](#164 (comment)), this PR adds supports for DPKG parsing. Structure is similar to APK parser. --------- Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com> Co-authored-by: Gareth Jones <Jones258@Gmail.com>
hayleycd
pushed a commit
that referenced
this pull request
Mar 9, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in #168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in #149. Thank you, Regards.
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
As discussed in google#164 [here](google#164 (comment)), this PR adds supports for DPKG parsing. Structure is similar to APK parser. --------- Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com> Co-authored-by: Gareth Jones <Jones258@Gmail.com>
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in google#168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in google#149. Thank you, Regards.
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
As discussed in google#164 [here](google#164 (comment)), this PR adds supports for DPKG parsing. Structure is similar to APK parser. --------- Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com> Co-authored-by: Gareth Jones <Jones258@Gmail.com>
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in google#168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in google#149. Thank you, Regards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #164 here, this PR adds supports for DPKG parsing.
Structure is similar to APK parser.