Nits - APK installed optimizations#227
Merged
Merged
Conversation
Collaborator
they're public, so renaming them would be a breaking change - the comments should read "Would require a major version bump" |
cmaritan
force-pushed
the
nits-staticcheck-apk
branch
from
e4c5e15 to
cd3c357
Compare
Contributor
Author
|
Thank you for the clarification! |
cmaritan
changed the title
G-Rath
approved these changes
Feb 20, 2023
oliverchang
approved these changes
Feb 20, 2023
hayleycd
pushed a commit
that referenced
this pull request
Mar 9, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in #168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in #149. Thank you, Regards.
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in google#168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in google#149. Thank you, Regards.
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
Hello, ported to APK installed parser common optimizations already merged for DPKG in google#168. Additionally, a couple of staticcheck linter errors have been corrected (I think!). I saw the comments here: https://github.com/google/osv-scanner/blob/fb4d2c4d8e4e59961db70121e31870593e045a4e/pkg/osvscanner/osvscanner.go#L39-L43 but after my change both lints and tests are ok so it's not clear to me if comments are now out of date or if I'm missing something! Comments have been introduced in google#149. Thank you, Regards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
ported to APK installed parser common optimizations already merged for DPKG in #168.
Additionally, a couple of staticcheck linter errors have been corrected (I think!).
I saw the comments here:
osv-scanner/pkg/osvscanner/osvscanner.go
Lines 39 to 43 in fb4d2c4
Comments have been introduced in #149.
Thank you,
Regards.