Skip to content

Publish approved featured catalog icons - #81

Merged
aphansal123 merged 9 commits into
aphansal123-curated-resource-iconsfrom
aphansal123-featured-catalog-icon-data
Oct 14, 2026
Merged

aphansal123 merged 9 commits into
aphansal123-curated-resource-iconsfrom
aphansal123-featured-catalog-icon-data

Conversation

@aphansal123

@aphansal123 aphansal123 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

This pull request adds a new catalog-icons.json file containing metadata for a set of application and skill icons. Each entry includes an identifier, image URL, provenance details (such as source URL, approval statement, and SHA256 hash), ensuring traceability and compliance for icon assets in the catalog.

New asset catalog:

  • Added catalog-icons.json file listing icons for various apps and skills, each with a unique identifier, image URL, provenance information, and SHA256 hash for verification.

Provenance and compliance:

  • For each icon, included explicit approval statements for public redistribution and details on image processing, supporting compliance and transparency for asset usage.

aphansal123 and others added 2 commits October 13, 2026 22:57
Preserve reviewed artwork and declarations with immutable asset URLs. Add only icon metadata to the existing catalog resource snapshot.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b21c356f-7fbf-4392-8f95-f5c987dba212
Preserve approved data while using the icon-aware generator in CI.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b21c356f-7fbf-4392-8f95-f5c987dba212
@aphansal123
aphansal123 changed the base branch from main to aphansal123-curated-resource-icons October 14, 2026 03:00
Retain approved data and refresh live registry inputs with the icon-aware generator.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b21c356f-7fbf-4392-8f95-f5c987dba212
Co-authored-by: aphansal123 <21958153+aphansal123@users.noreply.github.com>
@github github deleted a comment from Copilot AI Oct 14, 2026
@aphansal123
aphansal123 requested a balanced review from Copilot October 14, 2026 14:05
@aphansal123 aphansal123 self-assigned this Oct 14, 2026
@aphansal123
aphansal123 marked this pull request as ready for review October 14, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Provenance URLs are inaccessible, and the generated catalog contains unrelated registry churn.

2 open findings
What changed in this PR

Publishes curated icons and attaches them to selected catalog resources.

Changes:

  • Adds provenance records for 13 resource identifiers.
  • Adds generated icon metadata.
  • Includes unrelated registry refresh changes.
File Description
catalog-icons.json Defines icon URLs, provenance, and hashes.
ai-catalog.json Publishes icon metadata and registry updates.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread catalog-icons.json Outdated
Comment thread ai-catalog.json Outdated
@@ -22533,7 +22543,7 @@
"model-context-protocol"
],
"version": "1.0.0",
"updatedAt": "2026-10-14T03:19:37Z",
"updatedAt": "2026-10-14T12:54:05Z",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unrelated registry refresh; the PR diff now contains only the intended icon metadata additions. Commit: f646a97.

@trent-j trent-j left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I do think we need to address this though before we can merge

Point provenance at immutable approved PNG exports instead of private repository links. Clarify the distinction from the private original artwork while preserving redistribution attestations and all asset pins and digests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b21c356f-7fbf-4392-8f95-f5c987dba212
Co-authored-by: aphansal123 <21958153+aphansal123@users.noreply.github.com>
@aphansal123
aphansal123 requested a review from trent-j October 14, 2026 14:38

@trent-j trent-j left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon-ic

@aphansal123
aphansal123 merged commit 5c28955 into aphansal123-curated-resource-icons Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants