Repository navigation
Enable reviewed catalog icon declarations - #79
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
Publish selected image assets independently so declarations can reference this immutable commit. No app code or repository visibility changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
Record explicit redistribution approval without inventing a license or permission URL. Include selected icon and cover artwork and add the missing Web Design Guidelines skill entry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
aphansal123
changed the title
Defer its icon declaration until the independently proposed skill entry is available. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
…esource-icons # Conflicts: # ai-catalog.json Co-authored-by: aphansal123 <21958153+aphansal123@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Binary provenance, redistribution approval, and downstream deployment dependencies require final human verification.
0 open findings
What changed in this PR
Adds a reviewed-icon overlay system for catalog resources, including validation, publication, documentation, and generated metadata.
Changes:
- Validates curated PNG assets, provenance, immutable URLs, and overlay declarations.
- Publishes 13 icon mappings and regenerates the catalog.
- Adds comprehensive tests, documentation, and workflow triggers.
| File | Description |
|---|---|
.github/workflows/catalog.yml |
Triggers validation for icon-related changes. |
CONTRIBUTING.md |
Documents icon review and maintenance. |
README.md |
Describes the optional icon system. |
catalog-icons.json |
Declares 13 reviewed icon mappings. |
ai-catalog.json |
Publishes generated icon metadata and registry refreshes. |
scripts/generate_ai_catalog.py |
Validates and applies icon declarations. |
tests/test_generate_ai_catalog.py |
Tests overlay and PNG validation. |
tests/test_catalog_workflow.py |
Tests workflow path triggers. |
icons/atlassian-labs/jira.png |
Adds Jira artwork. |
icons/figma/figma.png |
Adds Figma artwork. |
icons/github/security-best-practices.png |
Adds GitHub security artwork. |
icons/mattpocock/grill-me.png |
Adds Grill Me artwork. |
icons/microsoft/azure-devops.png |
Adds Azure DevOps artwork. |
icons/microsoft/azure.png |
Adds Azure artwork. |
icons/microsoft/microsoft-foundry.png |
Adds Foundry artwork. |
icons/microsoft/playwright.png |
Adds Playwright artwork. |
icons/microsoft/workiq.png |
Adds Work IQ artwork. |
icons/pbakaus/impeccable.png |
Adds Impeccable artwork. |
icons/sentry/sentry-triage.png |
Adds Sentry artwork. |
icons/vercel-labs/web-design-guidelines.png |
Stages deferred Web Design Guidelines artwork. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Move featured assets and declarations to a dependent data PR. Replace custom PNG parsing with Pillow verification and decoding, retaining byte/dimension/static-image limits and provenance checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
…ns' into aphansal123-curated-resource-icons
aphansal123
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50237efe-1a63-4ebe-96da-802b873d8c09
trent-j
approved these changes
Oct 14, 2026
aphansal123
marked this pull request as ready for review
October 14, 2026 14:38
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves github/copilot-ecosystem#1624
This pull request introduces support for reviewed resource icons in the catalog, including the infrastructure for validating, declaring, and applying curated icon assets to catalog entries. It also updates documentation and workflow automation to support and enforce these changes. The main themes are: icon overlay and validation, workflow and documentation updates, and codebase changes for icon handling.
Reviewed icon support and validation:
catalog-icons.jsonoverlay file to declare optional reviewed icons for both contributor-managed and registry-imported resources, using exacturn:air:identifiers and optional versions. The overlay includes provenance, permission, and SHA-256 verification for each asset.Catalog generation and codebase updates:
scripts/generate_ai_catalog.pyto load, validate, and apply icon declarations from the overlay, injecting curated icon URLs into generated catalog entries' metadata. Direct icon metadata in source entries is now rejected; only the overlay can supply it.Workflow and documentation improvements:
catalog-icons.json,icons/**,requirements.txt, and documentation files, ensuring icon and validation changes are tested in CI.CONTRIBUTING.mdandREADME.md, including detailed instructions for adding, replacing, and removing icons, and the rationale for curation and provenance.These changes lay the groundwork for curated icon support in the catalog, with robust validation and clear contribution guidelines.