Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- Android: Expose app-hang detection through the NDK bindings via `NdkOptions.setEnableAppHangTracking()` and `NdkOptions.setAppHangTimeoutMillis()`. ([#1823](https://github.com/getsentry/sentry-native/pull/1823))

**Fixes**:

- Native/Windows: ensure valid event IDs for fast-fail crash envelopes to fix launching of the external crash reporter for fast-fail crashes. ([#1832](https://github.com/getsentry/sentry-native/pull/1832))

## 0.15.2

**Fixes**:
Expand Down
2 changes: 2 additions & 0 deletions src/backends/native/sentry_crash_daemon.c
Original file line number Diff line number Diff line change
Expand Up @@ -2373,6 +2373,8 @@ build_native_event(const sentry_crash_context_t *ctx,

if (sentry_value_is_null(event)) {
event = sentry_value_new_event();
} else {
sentry__ensure_event_id(event, NULL);
}

apply_breadcrumbs_from_ring_files(event, run_folder, ctx);
Expand Down
2 changes: 2 additions & 0 deletions tests/assertions.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,10 @@ def assert_inproc_crash(envelope):


def assert_native_crash(envelope, exception_code=None):
assert envelope.headers["event_id"]
event = envelope.get_event()
assert event is not None
assert event["event_id"]
assert_matches(event, {"level": "fatal"})

exc = event["exception"]["values"][0]
Expand Down
4 changes: 4 additions & 0 deletions tests/test_integration_native.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ def test_native_capture_crash(cmake, httpserver):
)
assert waiting.result

assert len(httpserver.log) >= 1
envelope = Envelope.deserialize(httpserver.log[0][0].get_data())
assert_native_crash(envelope)


@pytest.mark.skipif(
sys.platform != "win32" or bool(os.environ.get("TEST_MINGW")),
Expand Down
Loading