Skip to content

fix(native): ensure event ID for fastfail crashes#1832

Open
jpnurmi wants to merge 3 commits into
masterfrom
jpnurmi/fix/native/event-id
Open

fix(native): ensure event ID for fastfail crashes#1832
jpnurmi wants to merge 3 commits into
masterfrom
jpnurmi/fix/native/event-id

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

This PR ensures that fast-fail crash envelopes have valid event IDs, which is required for resolving the correct envelope path when launching the external crash reporter.

For normal SEH crashes, native_backend_except is called, and it populates the event with a valid event ID by calling sentry_value_new_event. For fast-fail crashes captured via WER, however, the app callback cannot be called, and __sentry-event was therefore left without a valid ID. Consequently, the envelope's filename couldn't be correctly resolved when launching the external crash reporter for fast-fail crashes.

Before After
image image

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 165a2c1. Configure here.

Comment thread tests/test_integration_native.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant