Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52412d26ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const initiator = args.payload.senderThreadId | ||
| ? "agent" | ||
| : args.startedOnBehalfOf?.initiator; |
There was a problem hiding this comment.
Classify self-senders after normalization
When a send supplies senderThreadId equal to the target thread ID, resolveMessageSenderThreadId intentionally normalizes it to null, so the persisted request is user-initiated. This pre-resolution check instead labels the telemetry origin as agent and disables user_message_sent, producing incorrect message and turn analytics. createQueuedMessageForThread repeats the same raw-field check, so explicit queued messages have the same problem; derive telemetry authorship from the normalized sender in both paths.
Useful? React with 👍 / 👎.
a96ef8f to
70f6119
Compare
b86ffd5 to
dd100f8
Compare
dd100f8 to
fe24b02
Compare
|
This is an automated message. We have closed this pull request because it has been open for more than two weeks. |
Human comments
What was wrong
Accepted messages could lose their anonymous link to later turn events. Replacing existing captures could suppress events when work telemetry was disabled.
What changed
Stack order: #5947 → #5437 → #5477 → #5469 → #5470 → #5471 → #5472 → #5473 → #5439.
How you verified
BB-Thread-ID: thr_swe8w7rxcm
BB-Thread-ID: thr_nq42ntdw95
BB-Thread-ID: thr_k4ic49de34