Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47582e7e65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| z | ||
| .object({ | ||
| name: z.literal("feature_used"), | ||
| properties: coreFeatureUsedPropertiesSchema, | ||
| }) |
There was a problem hiding this comment.
Because experimental_recordTelemetryEvent is exposed to plugins through packages/sdk/src/areas/system.ts, adding feature_used here lets any installed plugin submit events labeled as core usage with an arbitrary core feature, interaction, and trigger. The server route forwards the validated payload unchanged, so plugin-generated events are indistinguishable from the observations added by this commit and can corrupt capability-usage experiments; core-only events need a path or server-side attribution that plugins cannot claim.
Useful? React with 👍 / 👎.
| register("thread", [ | ||
| routes.threads.create, | ||
| routes.threads.fork, |
There was a problem hiding this comment.
When POST /threads receives the supported parentThreadId field, it creates a hierarchical child thread, but this unconditional registration emits feature: "thread". No producer elsewhere emits the newly declared child_thread feature, so normal child-thread creation is counted in the wrong capability bucket and the child-thread metric remains zero; derive the feature from the created thread/request rather than classifying every create request as a root thread.
Useful? React with 👍 / 👎.
04e96fb to
a1d3c82
Compare
5bde677 to
2ea2674
Compare
2ea2674 to
46c5a16
Compare
Human comments
What was wrong
Core actions and panel opens lacked a shared way to record anonymous capability use. Actor and feature names were inconsistent.
What changed
BB_FF_WORK_TELEMETRYis enabled.Stack order: #5947 → #5437 → #5477 → #5469 → #5470 → #5471 → #5472 → #5473 → #5439. #5947 supplies the shared initiator resolver.
How you verified
BB-Thread-ID: thr_a4mhd93zji
BB-Thread-ID: thr_nq42ntdw95
BB-Thread-ID: thr_k4ic49de34