Skip to content

docs(skills): document the social client APIs in magic_starter 0.0.39 and magic_social_auth 0.0.8 - #217

Merged
anilcancakir merged 2 commits into
masterfrom
docs/social-skills
Oct 5, 2026
Merged

anilcancakir merged 2 commits into
masterfrom
docs/social-skills

Conversation

@anilcancakir

Copy link
Copy Markdown
Member

Summary

Rewrites the magic-framework skill references for the redesigned social client stack:

  • references/plugin-social-auth.md documents magic_social_auth 0.0.8 (native ID-token and backend-hosted PKCE flows, SocialAuthResult, social:install and social:doctor).
  • references/plugin-starter.md documents magic_starter 0.0.39 (MagicStarterSocialAuth bridge, connected accounts, step-up confirmation, set password, scheduled and immediate account deletion).

magic_starter's skill_reference_stamp_test.dart reads these stamps, so its 0.0.39 release depends on this landing first.

Test plan

  • CI green (docs-only change, no code under lib/)

@kodizm

kodizm Bot commented Oct 5, 2026

Copy link
Copy Markdown

Note

Kodizm (AI-generated). May contain mistakes; verify before acting.

Docs-only change. The two references agree with each other, but the change set is missing the CHANGELOG entry and SKILL.md sync that this repo's skill edits normally carry.

Minor

CHANGELOG.md: There is no entry under ## [Unreleased] for either reference rewrite. The repo records skill-reference changes there, even a stamp bump on its own (0.0.26 has "The magic-framework skill reference stamps magic_notifications 0.3.7", and #207 added one for plugin-sentry.md). A BREAKING rewrite of plugin-social-auth.md deserves at least the same. (maintainability)

skills/magic-framework/SKILL.md:5: The version: 0.1.59 line is unchanged. CLAUDE.md post-change sync item 4 asks for "SKILL.md + the matching references/<topic>.md … bump the SKILL.md version line", and the docs-only #207 bumped it. Also, SKILL.md:426 still describes the plugin as "Social login (Google/Microsoft/GitHub)", but the new reference makes Apple a first-class native provider. (maintainability)

Tests

Nothing in this repo covers this change. The PR says magic_starter's skill_reference_stamp_test.dart reads the v0.0.39 stamp, and the header at plugin-starter.md:1 matches the format that test would parse.

CI

  • Lint & Test: success
  • Generated code analyzes: success
  • Auto-merge low-risk Dependabot PRs: skipped

I read both changed files in full and checked them against each other. The proof / useSocialAuth / doDeleteAccount descriptions are consistent across the two pages, and no other page in skills/ or doc/ still mentions the removed useSocialLogin / socialLoginBuilder. I could not check the documented APIs against the magic_starter 0.0.39 and magic_social_auth 0.0.8 sources, because neither package is in this checkout.

@kodizm

kodizm Bot commented Oct 5, 2026

Copy link
Copy Markdown

Note

Kodizm (AI-generated). May contain mistakes; verify before acting.

The new commits fix both findings from the last review. I found nothing new to flag.

Since 4faca25, this PR adds an ## [Unreleased] → ### Changed entry to CHANGELOG.md that names all three skill files and both stamps. It also bumps SKILL.md to version: 0.1.60, with a matching header comment dated 2026-10-05. The plugin table at SKILL.md:426 now lists Google/Apple/GitHub/Microsoft. No other file in the repo still says 0.1.59, and the changelog entry follows the format of the earlier skill-stamp entries.

Tests

No tests in this repo cover this. The change touches docs and metadata only.

CI

  • Lint & Test: success
  • Generated code analyzes: success
  • Internal Links & Anchors: success
  • External Links: skipped
  • Auto-merge low-risk Dependabot PRs: skipped

This incremental review covered only CHANGELOG.md and skills/magic-framework/SKILL.md. I read both diffs in full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant