Replace non-portable M_PI with constants::pi()#553
Open
traversaro wants to merge 2 commits into
Open
Conversation
Merged
5 tasks
Contributor
Author
Member
|
@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix? |
Contributor
Author
I am not sure. Perhaps it is the mitigation against mining for which mantainers need to manually allow CI jobs from PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to:
Problem originally experienced in conda-forge/fcl-feedstock#11, but it seems it was also experienced in #546 .
This change is