Update to 0.7.0, add traversaro as mantainers and use ninja on Windows by traversaro · Pull Request #11 · conda-forge/fcl-feedstock

traversaro · 2021-11-12T19:22:23Z

Version of #9 updated removing the patches as they were accepted upstream in flexible-collision-library/fcl#530 . Furthermore, switch arm64 and ppc64 to use cross-compilation as otherwise build in emulation is quite slow.
Adding myself as mantainer in the repo as currently @wolfv is the only mantainer.
I also switched to use Ninja on Windows to speed up a bit the build.

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

…a-forge-pinning 2021.09.10.04.35.28

conda-forge-linter · 2021-11-12T19:22:27Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro · 2021-11-12T19:23:53Z

@conda-forge-admin, please rerender

github-actions · 2021-11-12T19:25:23Z

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the patch-2
branch of traversaro/fcl-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts cannot be rerendered because of GitHub
permissions.

…nda-forge-pinning 2021.11.12.17.05.18

conda-forge-linter · 2021-11-12T19:54:04Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

There are 1 too many lines. There should be one empty line at the end of the file.

conda-forge-linter · 2021-11-12T19:54:50Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

…nda-forge-pinning 2021.11.12.17.05.18

traversaro · 2021-11-13T11:34:06Z

Windows fails with:

[ 73%] Building CXX object test/CMakeFiles/test_fcl_collision.dir/test_fcl_collision.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W1'
test_fcl_collision.cpp
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1271): error C2338: You've instantiated std::aligned_storage<Len, Align> with an extended alignment (in other words, Align > alignof(max_align_t)). Before VS 2017 15.8, the member type would non-conformingly have an alignment of only alignof(max_align_t). VS 2017 15.8 was fixed to handle this correctly, but the fix inherently changes layout and breaks binary compatibility (*only* for uses of aligned_storage with extended alignments). Please define either (1) _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand this message and that you actually want a type with an extended alignment, or (2) _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and get the old non-conformant behavior.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1291): note: see reference to class template instantiation 'std::_Aligned<592,16,double,false>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1298): note: see reference to class template instantiation 'std::_Aligned<592,16,int,false>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1305): note: see reference to class template instantiation 'std::_Aligned<592,16,short,false>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1312): note: see reference to class template instantiation 'std::_Aligned<592,16,char,false>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1320): note: see reference to class template instantiation 'std::aligned_storage<592,16>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1352): note: see reference to alias template instantiation 'std::aligned_storage_t<592,16>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\type_traits(1357): note: see reference to class template instantiation 'std::aligned_union<1,_Ty>' being compiled

traversaro · 2021-11-13T11:39:33Z

Windows fails with:

This error is similar to conda-forge/rbdl-feedstock#27 and conda-forge/libignition-physics-feedstock#12 (comment) . In ign-physics, we defined that symbol in a VS2017-specific patch: https://github.com/conda-forge/libignition-physics-feedstock/blob/a3500e5ea3fb81049074fd41f6aa600173da7ff3/recipe/vs2017_support.patch .

traversaro · 2021-11-13T14:16:10Z

New CI failure:

2021-11-13T13:49:02.4680274Z [170/200] Building CXX object test\geometry\shape\CMakeFiles\test_convex.dir\test_convex.cpp.obj
2021-11-13T13:49:02.4681650Z FAILED: test/geometry/shape/CMakeFiles/test_convex.dir/test_convex.cpp.obj 
2021-11-13T13:49:02.4701118Z C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_DONT_DEFINE_ASSERT_EQ=1 -DGTEST_DONT_DEFINE_ASSERT_GE=1 -DGTEST_DONT_DEFINE_ASSERT_GT=1 -DGTEST_DONT_DEFINE_ASSERT_LE=1 -DGTEST_DONT_DEFINE_ASSERT_LT=1 -DGTEST_DONT_DEFINE_ASSERT_NE=1 -DGTEST_DONT_DEFINE_FAIL=1 -DGTEST_DONT_DEFINE_SUCCEED=1 -DGTEST_DONT_DEFINE_TEST=1 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -I%SRC_DIR%\test -I%SRC_DIR%\test\gtest -I%SRC_DIR%\test\gtest\include -I%SRC_DIR%\build\include -I%SRC_DIR%\include -I%SRC_DIR%\test\. -I%SRC_DIR%\build\test -I%PREFIX%\Library\include -I%PREFIX%\Library\include\eigen3 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /EHsc /MP /W1 /bigobj /MD /O2 /Ob2 /DNDEBUG /showIncludes /Fotest\geometry\shape\CMakeFiles\test_convex.dir\test_convex.cpp.obj /Fdtest\geometry\shape\CMakeFiles\test_convex.dir\ /FS -c %SRC_DIR%\test\geometry\shape\test_convex.cpp
2021-11-13T13:49:02.4708239Z cl : Command line warning D9025 : overriding '/W3' with '/W1'
2021-11-13T13:49:02.4715376Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(780): error C2065: 'M_PI': undeclared identifier
2021-11-13T13:49:02.4723690Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(780): error C2789: 'dphi': an object of const-qualified type must be initialized
2021-11-13T13:49:02.4724754Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(780): note: see declaration of 'dphi'
2021-11-13T13:49:02.4725572Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(793): error C2065: 'M_PI': undeclared identifier
2021-11-13T13:49:02.4726728Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(793): error C2789: 'dtheta': an object of const-qualified type must be initialized
2021-11-13T13:49:02.4727578Z %SRC_DIR%\test\geometry\shape\test_convex.cpp(793): note: see declaration of 'dtheta'

Fix proposed upstream in flexible-collision-library/fcl#553 and backported in this PR.

traversaro · 2021-11-13T15:57:51Z

Windows fails with:

[177/200] Building CXX object test\geometry\shape\CMakeFiles\test_convex.dir\test_convex.cpp.obj
FAILED: test/geometry/shape/CMakeFiles/test_convex.dir/test_convex.cpp.obj 
C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_DONT_DEFINE_ASSERT_EQ=1 -DGTEST_DONT_DEFINE_ASSERT_GE=1 -DGTEST_DONT_DEFINE_ASSERT_GT=1 -DGTEST_DONT_DEFINE_ASSERT_LE=1 -DGTEST_DONT_DEFINE_ASSERT_LT=1 -DGTEST_DONT_DEFINE_ASSERT_NE=1 -DGTEST_DONT_DEFINE_FAIL=1 -DGTEST_DONT_DEFINE_SUCCEED=1 -DGTEST_DONT_DEFINE_TEST=1 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -I%SRC_DIR%\test -I%SRC_DIR%\test\gtest -I%SRC_DIR%\test\gtest\include -I%SRC_DIR%\build\include -I%SRC_DIR%\include -I%SRC_DIR%\test\. -I%SRC_DIR%\build\test -I%PREFIX%\Library\include -I%PREFIX%\Library\include\eigen3 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /EHsc /MP /W1 /bigobj /MD /O2 /Ob2 /DNDEBUG /showIncludes /Fotest\geometry\shape\CMakeFiles\test_convex.dir\test_convex.cpp.obj /Fdtest\geometry\shape\CMakeFiles\test_convex.dir\ /FS -c %SRC_DIR%\test\geometry\shape\test_convex.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W1'
d:\bld\fcl_1636813126473\work\test\eigen_matrix_compare.h(66) : fatal error C1002: compiler is out of heap space in pass 2
[178/200] Building CXX object test\narrowphase\detail\CMakeFiles\test_collision_func_matrix.dir\test_collision_func_matrix.cpp.obj
FAILED: test/narrowphase/detail/CMakeFiles/test_collision_func_matrix.dir/test_collision_func_matrix.cpp.obj 
C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_DONT_DEFINE_ASSERT_EQ=1 -DGTEST_DONT_DEFINE_ASSERT_GE=1 -DGTEST_DONT_DEFINE_ASSERT_GT=1 -DGTEST_DONT_DEFINE_ASSERT_LE=1 -DGTEST_DONT_DEFINE_ASSERT_LT=1 -DGTEST_DONT_DEFINE_ASSERT_NE=1 -DGTEST_DONT_DEFINE_FAIL=1 -DGTEST_DONT_DEFINE_SUCCEED=1 -DGTEST_DONT_DEFINE_TEST=1 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -I%SRC_DIR%\test -I%SRC_DIR%\test\gtest -I%SRC_DIR%\test\gtest\include -I%SRC_DIR%\build\include -I%SRC_DIR%\include -I%SRC_DIR%\test\. -I%SRC_DIR%\build\test -I%PREFIX%\Library\include -I%PREFIX%\Library\include\eigen3 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /EHsc /MP /W1 /bigobj /MD /O2 /Ob2 /DNDEBUG /showIncludes /Fotest\narrowphase\detail\CMakeFiles\test_collision_func_matrix.dir\test_collision_func_matrix.cpp.obj /Fdtest\narrowphase\detail\CMakeFiles\test_collision_func_matrix.dir\ /FS -c %SRC_DIR%\test\narrowphase\detail\test_collision_func_matrix.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W1'
d:\bld\fcl_1636813126473\_h_env\library\include\eigen3\eigen\src/Core/Block.h(110): fatal error C1060: compiler is out of heap space
[179/200] Building CXX object test\CMakeFiles\test_fcl_sphere_cylinder.dir\test_fcl_sphere_cylinder.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W1'

Better to go back to use NMake so we do not have parallel builds.

wolfv · 2021-11-13T21:35:37Z

Thanks awesome!

traversaro · 2021-11-13T23:41:20Z

Thanks awesome!

Thanks for merging!

regro-cf-autotick-bot and others added 3 commits September 10, 2021 05:57

updated v0.7.0

7c9444f

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and cond…

e040edf

…a-forge-pinning 2021.09.10.04.35.28

Remove patches

6a96021

traversaro requested a review from wolfv as a code owner November 12, 2021 19:22

Delete fix-win.patch

85ccad1

MNT: Re-rendered with conda-build 3.21.6, conda-smithy 3.14.3, and co…

ed0b947

…nda-forge-pinning 2021.11.12.17.05.18

traversaro changed the title ~~Update to 0.7.0~~ Update to 0.7.0 and add traversaro as mantainers Nov 12, 2021

Update meta.yaml

77c34c6

Update meta.yaml

2f3b9e7

traversaro added 2 commits November 12, 2021 21:35

Switch to cross-compile for ppc64 and aarch64

4c3dae0

MNT: Re-rendered with conda-build 3.21.6, conda-smithy 3.14.3, and co…

bbe1330

…nda-forge-pinning 2021.11.12.17.05.18

traversaro added 4 commits November 13, 2021 12:44

Create win2017_support.patch

93aad60

Update meta.yaml

a2ebc90

Update bld.bat

6089823

Update meta.yaml

2bb8ff5

traversaro changed the title ~~Update to 0.7.0 and add traversaro as mantainers~~ Update to 0.7.0, add traversaro as mantainers and use ninja on Windows Nov 13, 2021

traversaro added 2 commits November 13, 2021 15:13

Update meta.yaml

789b904

Create 553.patch

6a3e404

This was referenced Nov 13, 2021

Replace non-portable M_PI with constants::pi() flexible-collision-library/fcl#553

Open

dartsim v6.11.0 conda-forge/dartsim-feedstock#16

Merged

Update bld.bat

98ada51

Update meta.yaml

89c7ab9

wolfv merged commit 8e55f58 into conda-forge:master Nov 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update to 0.7.0, add traversaro as mantainers and use ninja on Windows#11

Update to 0.7.0, add traversaro as mantainers and use ninja on Windows#11
wolfv merged 17 commits into
conda-forge:masterfrom
traversaro:patch-2

traversaro commented Nov 12, 2021 •

edited

Loading

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

traversaro commented Nov 12, 2021

Uh oh!

github-actions Bot commented Nov 12, 2021

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

wolfv commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

traversaro commented Nov 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

traversaro commented Nov 12, 2021

Uh oh!

github-actions Bot commented Nov 12, 2021

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

conda-forge-linter commented Nov 12, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

wolfv commented Nov 13, 2021

Uh oh!

traversaro commented Nov 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

traversaro commented Nov 12, 2021 •

edited

Loading