Repository navigation
Conversation
The dummy app never ran: ember-classic-decorator (unused) crashes on Ember 5, lazy loading kept the engine's modules out of the test bundle, and the host services, config and intl data the panels need were missing. Mirrors what fleetops already does: eager loading when `ember test` runs from this package, an inert stand-in for the console's extensions module, the API config the core adapter reads at module scope, and the legacy built-in components the engine's templates still use. The dummy intl service ignores missing locale data, since headless Chrome has no number formats for every bundled locale, and the order details and network controller tests stub the host router, fetch and app cache the way the widget tests already do.
This was referenced Oct 10, 2026
Member
Author
|
Superseded by the single overhaul PR (one branch, one PR targeting release/v0.4.25, per maintainer request). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Follow-up to #120. The engine's dummy test app could not boot at all in this package, so no
ember testrun had ever executed the suite (CI only runs the build). This makes it bootable and makes the tests #120 added pass:ember-classic-decoratordevDependency, whose vendor shim throws on Ember 5 (Ember.AutoLocationno longer exists) before any module loads.@ember/legacy-built-in-componentsas a devDependency, as fleetops and the console declare it; the engine's templates still use the legacy built-ins.ember testruns from this package, so the engine's modules are in the dummy bundle (consumers keep lazy loading), plus the inert stand-in for the console's generated extensions module in the test helper.APIconfig@fleetbase/ember-core's adapter reads at module scope, and an intl service that ignores missing locale data, since headless Chrome ships no number formats for every bundled locale (Mongolian among them) and ember-intl otherwise throws in whichever test first touches intl.setupIntl, a host-router stub for the network controllers, and fetch and app-cache stubs for the order details panels, the way the widget tests already stub them; the order details title assertions now check every panel title instead of only the first.pnpm-lock.yamlregenerated with pnpm 11.20.0 for the two devDependency changes only.Why was this change needed?
Without it the identity-cell, pill and controller tests from #120 cannot run anywhere.
Other information
Validation, run locally against the linked fleetops-data branch (fleetbase/fleetops-data#87):
The rest of the legacy suite now boots but still has many pre-existing failures, mostly generated "it renders" stubs asserting empty output from modals that render content, plus device and telematic tests; those are out of scope here. Consider adding
pnpm test:emberto CI once they are repaired.Note: the branch
feat/shared-identity-componentsstill carries this commit on top of duplicate copies of the multi-store checkout commits that were committed on it after #120 merged; this PR is the clean version. That branch can be deleted.