Repository navigation
Conversation
The dummy app never ran: ember-classic-decorator (unused) crashes on Ember 5, lazy loading kept the engine's modules out of the test bundle, and the host services, config and intl data the panels need were missing. Mirrors what fleetops already does: eager loading when `ember test` runs from this package, an inert stand-in for the console's extensions module, the API config the core adapter reads at module scope, and the legacy built-in components the engine's templates still use. The dummy intl service ignores missing locale data, since headless Chrome has no number formats for every bundled locale, and the order details and network controller tests stub the host router, fetch and app cache the way the widget tests already do.
… is only found by its own storefront
…rce card Catalog, truck and network index pages use Layout::Resource::CardsGrid with one card each on Layout::Resource::Card, following the Fleet-Ops anatomy: identity and subtitle in the header, media or facts in the body, status, icon actions and meta in the footer, with registry slots at each end. A catalog card shows its categories with product counts, its hours as a seven-day strip (the new Storefront::HoursStrip) and its product total; a draft is dashed. A truck card is a Vehicle::Pill with the online dot, the vehicle photo, where it serves, and a presence badge that says serving, offline, inactive, or online with no catalog. A network card shows the logo on its backdrop, the online state, the currency and member count. "Food trucks" reads "Trucks" in the UI; the food-truck model, routes and permissions keep their names. The catalogs and trucks pages gain the search the header already offered.
…ut a vehicle renders its placeholder
Member
Author
|
Validation on The first run had the two truck card tests failing; |
8 of 16 tasks
… and crashed createRecord; the store summary is store_summary
Member
Author
|
Superseded by the single overhaul PR (one branch, one PR targeting release/v0.4.25, per maintainer request). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
First implementation step of the Storefront UX overhaul (design canvas boards 4, 9a and 9c): the catalog, truck and network index pages move from hand-rolled boxes to the shared card anatomy Fleet-Ops uses, on
Layout::Resource::CardsGridandLayout::Resource::Card.Storefront::Catalog::Card: name and status in the header, the categories it contains with product counts, a seven-day hours strip, the product total, edit and delete. A draft catalog is dashed; an empty one says so. Clicking the name opens the editor.Storefront::Truck::Card: aVehicle::Pill(photo, plate, online dot) as the identity, the service area and zone as subtitle, the vehicle photo as media, and a presence badge that says what matters to a store: serving, offline, inactive, or online with no catalog. Catalog count and, when the API sends it, the owning store.Storefront::Network::Card: logo on backdrop, online indicator, currency and member count, open, invite and delete.Storefront::HoursStrip: a reusable strip from any list ofday_of_week/start/endrecords (catalog, store and product hours), with each day's hours as its title.storefront:component:<resource>:card:header|footer:start|endregistry slots, like the Fleet-Ops cards.queryparam the routes refresh on); networks keep theirs and gain the grid's pagination.food-truckmodel, routes, permissions and translation keys keep their names, as agreed. The copy-pasted "Edit Food Truck" title on the catalog editor is fixed.food-truckmodel gains theonlineandstoreattributes the resource already returns.storefront-card*block andstorefront-hours-strip*instorefront-engine.css, mirroring thefleetops-card*values.Why was this change needed?
The three pages rendered their own boxes with different spacing, no status, no counts and no empty states. One anatomy, restyled once in ember-ui later, is the point of the overhaul; the generic
Resource::Cardprimitive proposed for ember-ui will replace these three thin components when it ships.Other information
Stacked on #121 (the test-environment fixes); until #121 merges this PR shows that commit too. Target is
release/v0.4.25.Validation, run locally with the linked fleetops-data branch:
New tests cover the hours strip, the three cards (content, states, actions, empty and draft cases) and the existing controller tests still pass.
i18n: new
storefront.catalogs.*,storefront.trucks.*,storefront.networks.card.*andstorefront.common.offline|last-modifiedkeys inen-usonly; other locales fall back to the key until translated. No API orfleetbase/postmanimpact; the fleetbase.io docs screenshots of the three pages will be out of date.