Repository navigation
Order config lifecycle management, full config list, live activity timeline - #350
Merged
Merged
Conversation
…meline - Order Config: add a Lifecycle tab to view and edit `meta.lifecycle` (initial, completed, canceled and terminal activities, dispatch, strict transitions), with validation against the activity flow. - Order Config: always fetch the config list. `findAll` resolved with the subset the store already held (e.g. an order's embedded config) and only refreshed in the background, so configs created later were missing from the manager. - Order details: reload the activity timeline when the order's status changes outside the Update Activity modal (configured lifecycle advancing on save, extension actions, realtime updates).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from testing the configured order lifecycle (merged in #346) with the Porsche RSA Loan extension.
meta.lifecyclefrom the console: initial activity, completed / canceled activities, terminal activities, allow dispatch, strict transitions. Options come from the config's activity flow; a lifecycle that references an activity missing from the flow cannot be saved. Removing the configured lifecycle asks for confirmation and restores the default dispatch lifecycle. Before this there was no way to see whether a config had a configured lifecycle, let alone manage it.loadOrderConfigsusedstore.findAll('order-config'), which resolves immediately with whatever configs the store already holds (for example a single config embedded in an order loaded earlier) and only refreshes in the background —Array.fromthen froze that partial list. Configs created after the console session started (here, the extension-installed RSA Loan config) never appeared in the selector. It now fetches withreload: true.Order::Details::Activityonly reloaded tracking statuses through the Update Activity modal. With a configured lifecycle the status can change on an ordinary save (e.g. assigning a vehicle advances the order), through an extension action, or through a realtime update, leaving the timeline stale until a page reload. The panel now reloads activity when the order'sstatuschanges.Test plan
meta.lifecyclepersisted; toggling off asks for confirmation and removes it.ember-template-lint/eslintpass on the changed files (run locally).