Skip to content

Activity flow: tolerate cyclic flows; Lifecycle tab: inline save button - #351

Merged
roncodes merged 1 commit into
release/v0.6.71from
fix/order-config-lifecycle-management
Oct 5, 2026
Merged

roncodes merged 1 commit into
release/v0.6.71from
fix/order-config-lifecycle-management

Conversation

@roncodes

@roncodes roncodes commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #350.

  • Activity Flow crashed on cyclic flows. addChildActivities walked the flow as a tree and recursed forever when a configured lifecycle loops back (the RSA Loan config has active → extended → active), until JointJS overflowed the stack (Invalid regular expression ... Stack overflow from delegateEvents) when opening the Activity Flow tab. An activity already on the graph now only receives a link from the additional parent and is not placed or walked again. This also covers an activity reachable from several parents.
  • Lifecycle tab: the save button sits under the form instead of in a separate collapsible "Controls" panel.

Test plan

  • Open the Activity Flow tab of a config whose flow has a cycle (e.g. the Porsche RSA Loan config) — it renders, with a back-link, instead of crashing.
  • Lifecycle tab: edit and save still works; the save button is under the form.

A configured lifecycle can loop back (active -> extended -> active) and an
activity can have several parents. addChildActivities walked the flow as a
tree and recursed forever on a cycle until JointJS overflowed the stack when
opening the Activity Flow tab. An activity already on the graph now only gets
a link from the additional parent.

The Lifecycle tab's save button sits under the form instead of in a separate
collapsible Controls panel.
@roncodes
roncodes merged commit d619db1 into release/v0.6.71 Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant