Repository navigation
Activity flow: tolerate cyclic flows; Lifecycle tab: inline save button - #351
Merged
Merged
Conversation
A configured lifecycle can loop back (active -> extended -> active) and an activity can have several parents. addChildActivities walked the flow as a tree and recursed forever on a cycle until JointJS overflowed the stack when opening the Activity Flow tab. An activity already on the graph now only gets a link from the additional parent. The Lifecycle tab's save button sits under the form instead of in a separate collapsible Controls panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #350.
addChildActivitieswalked the flow as a tree and recursed forever when a configured lifecycle loops back (the RSA Loan config hasactive → extended → active), until JointJS overflowed the stack (Invalid regular expression ... Stack overflowfromdelegateEvents) when opening the Activity Flow tab. An activity already on the graph now only receives a link from the additional parent and is not placed or walked again. This also covers an activity reachable from several parents.Test plan