Skip to content

Changed TrainCheckpointCallback to always save on_train_end #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MJordahn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed TrainCheckpointCallback to always save on_train_end #2020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/fairchem/core/components/train/train_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,11 @@ def on_train_step_start(self, state: State, unit: TTrainUnit) -> None:
shutil.rmtree(dir)

def on_train_end(self, state: State, unit: TTrainUnit) -> None:
if self.checkpoint_every_n_steps is not None:
# also always checkpoint on train end
assert (
self.save_callback
), "Must initialize set_checkpoint_call_backs from Runner!"
self.save_callback(os.path.join(self.checkpoint_dir, "final"))
# always checkpoint on train end
assert (
self.save_callback
), "Must initialize set_checkpoint_call_backs from Runner!"
self.save_callback(os.path.join(self.checkpoint_dir, "final"))


class TrainEvalRunner(Runner):
Expand Down
Loading