Changed TrainCheckpointCallback to always save on_train_end#2020
Open
MJordahn wants to merge 1 commit into
Open
Changed TrainCheckpointCallback to always save on_train_end#2020MJordahn wants to merge 1 commit into
TrainCheckpointCallback to always save on_train_end#2020MJordahn wants to merge 1 commit into
Conversation
…nCheckpointCallback is passed to training config
MJordahn
changed the title
TrainCheckpointCallback to always save on_train_end
rayg1234
approved these changes
Jun 4, 2026
rayg1234
left a comment
rayg1234
left a comment
Contributor
There was a problem hiding this comment.
looks good, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
TrainCheckpointCallbackto always saveon_train_endif aTrainCheckpointCallbackis passed to training config.TrainEvalRunnerautomatically creates directory for saving checkpoint, so should not be necessary inTrainCheckpointCallback.Fixes #2017.